All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rusty Russell <rusty@rustcorp.com.au>
To: Kevin Cernekee <cernekee@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org,
	Jan Beulich <JBeulich@novell.com>
Subject: Re: [PATCH V2 2/2] module: Fix performance regression on modules with large symbol tables
Date: Mon, 14 Nov 2011 11:05:14 +1030	[thread overview]
Message-ID: <87obwfpmm5.fsf@rustcorp.com.au> (raw)
In-Reply-To: <e80b536093214489c32ce319b54b0f80@localhost>

On Sat, 12 Nov 2011 19:08:56 -0800, Kevin Cernekee <cernekee@gmail.com> wrote:
> +			/*
> +			 * Copy the symbol name to mod->core_strtab.
> +			 * "name" might point to the middle of a longer strtab
> +			 * entry, so backtrack to the first "required" byte
> +			 * of the string.
> +			 */

Icky, but it works.

Both applied, thanks!
Rusty.

  reply	other threads:[~2011-11-14  0:49 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-13  3:08 [PATCH V2 1/2] module: Add comments describing how the "strmap" logic works Kevin Cernekee
2011-11-13  3:08 ` [PATCH V2 2/2] module: Fix performance regression on modules with large symbol tables Kevin Cernekee
2011-11-14  0:35   ` Rusty Russell [this message]
2011-11-14  8:48   ` Jan Beulich
2011-11-14  8:48     ` Jan Beulich
2011-11-16  0:24     ` Rusty Russell
2011-11-18  3:15     ` Kevin Cernekee
2011-11-18  3:15       ` Kevin Cernekee
2011-11-21  5:06       ` Rusty Russell
2011-11-21  6:29         ` Kevin Cernekee
2011-11-21 23:57           ` Rusty Russell
2011-11-21  8:08         ` Jan Beulich
2011-11-21  8:08           ` Jan Beulich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87obwfpmm5.fsf@rustcorp.com.au \
    --to=rusty@rustcorp.com.au \
    --cc=JBeulich@novell.com \
    --cc=cernekee@gmail.com \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.