diff for duplicates of <87obxkio3e.fsf@ti.com> diff --git a/a/1.txt b/N1/1.txt index 68d68b1..aa9ec72 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -14,20 +14,20 @@ Govindraj <govindraj.ti@gmail.com> writes: >> [...] >> >>> @@ -1305,6 +1363,16 @@ static int serial_omap_probe(struct platform_device *pdev) ->>> up->uart_dma.rx_dma_channel = OMAP_UART_DMA_CH_FREE; ->>> } +>>> ? ? ? ? ? ? ? up->uart_dma.rx_dma_channel = OMAP_UART_DMA_CH_FREE; +>>> ? ? ? } >>> ->>> + pm_runtime_use_autosuspend(&pdev->dev); ->>> + pm_runtime_set_autosuspend_delay(&pdev->dev, ->>> + OMAP_UART_AUTOSUSPEND_DELAY); +>>> + ? ? pm_runtime_use_autosuspend(&pdev->dev); +>>> + ? ? pm_runtime_set_autosuspend_delay(&pdev->dev, +>>> + ? ? ? ? ? ? ? ? ? ? OMAP_UART_AUTOSUSPEND_DELAY); >>> + ->>> + pm_runtime_irq_safe(&pdev->dev); ->>> + if (device_may_wakeup(&pdev->dev)) { ->>> + pm_runtime_enable(&pdev->dev); +>>> + ? ? pm_runtime_irq_safe(&pdev->dev); +>>> + ? ? if (device_may_wakeup(&pdev->dev)) { +>>> + ? ? ? ? ? ? pm_runtime_enable(&pdev->dev); >> >> So if device_may_wakeup() is false, runtime PM is not enabled, then... >> ->>> + pm_runtime_get_sync(&pdev->dev); +>>> + ? ? ? ? ? ? pm_runtime_get_sync(&pdev->dev); >> >> ...this get doesn't happen, and the first register access causes a crash. > @@ -46,7 +46,3 @@ Driver code should not make assumptions like this about what device init code is or isn't doing. Kevin --- -To unsubscribe from this list: send the line "unsubscribe linux-omap" in -the body of a message to majordomo@vger.kernel.org -More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/a/content_digest b/N1/content_digest index a56e00f..974e155 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -2,19 +2,10 @@ "ref\01317380495-584-9-git-send-email-govindraj.raja@ti.com\0" "ref\0878voplppo.fsf@ti.com\0" "ref\0CAAL8m4yrXo4KRYxXxWECU99B6--FCMBDFUbNk+vsBV0Jnt0bcg@mail.gmail.com\0" - "From\0Kevin Hilman <khilman@ti.com>\0" - "Subject\0Re: [PATCH v6 09/16] OMAP2+: UART: Add runtime pm support for omap-serial driver\0" + "From\0khilman@ti.com (Kevin Hilman)\0" + "Subject\0[PATCH v6 09/16] OMAP2+: UART: Add runtime pm support for omap-serial driver\0" "Date\0Thu, 13 Oct 2011 14:22:13 -0700\0" - "To\0Govindraj <govindraj.ti@gmail.com>\0" - "Cc\0Tony Lindgren <tony@atomide.com>" - Rajendra Nayak <rnayak@ti.com> - Partha Basak <p-basak2@ti.com> - Govindraj.R <govindraj.raja@ti.com> - Santosh Shilimkar <santosh.shilimkar@ti.com> - linux-serial@vger.kernel.org - Vishwanath Sripathy <vishwanath.bs@ti.com> - linux-omap@vger.kernel.org - " linux-arm-kernel@lists.infradead.org\0" + "To\0linux-arm-kernel@lists.infradead.org\0" "\00:1\0" "b\0" "Govindraj <govindraj.ti@gmail.com> writes:\n" @@ -33,20 +24,20 @@ ">> [...]\n" ">>\n" ">>> @@ -1305,6 +1363,16 @@ static int serial_omap_probe(struct platform_device *pdev)\n" - ">>> \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 up->uart_dma.rx_dma_channel = OMAP_UART_DMA_CH_FREE;\n" - ">>> \302\240 \302\240 \302\240 }\n" + ">>> ? ? ? ? ? ? ? up->uart_dma.rx_dma_channel = OMAP_UART_DMA_CH_FREE;\n" + ">>> ? ? ? }\n" ">>>\n" - ">>> + \302\240 \302\240 pm_runtime_use_autosuspend(&pdev->dev);\n" - ">>> + \302\240 \302\240 pm_runtime_set_autosuspend_delay(&pdev->dev,\n" - ">>> + \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 OMAP_UART_AUTOSUSPEND_DELAY);\n" + ">>> + ? ? pm_runtime_use_autosuspend(&pdev->dev);\n" + ">>> + ? ? pm_runtime_set_autosuspend_delay(&pdev->dev,\n" + ">>> + ? ? ? ? ? ? ? ? ? ? OMAP_UART_AUTOSUSPEND_DELAY);\n" ">>> +\n" - ">>> + \302\240 \302\240 pm_runtime_irq_safe(&pdev->dev);\n" - ">>> + \302\240 \302\240 if (device_may_wakeup(&pdev->dev)) {\n" - ">>> + \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 pm_runtime_enable(&pdev->dev);\n" + ">>> + ? ? pm_runtime_irq_safe(&pdev->dev);\n" + ">>> + ? ? if (device_may_wakeup(&pdev->dev)) {\n" + ">>> + ? ? ? ? ? ? pm_runtime_enable(&pdev->dev);\n" ">>\n" ">> So if device_may_wakeup() is false, runtime PM is not enabled, then...\n" ">>\n" - ">>> + \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 pm_runtime_get_sync(&pdev->dev);\n" + ">>> + ? ? ? ? ? ? pm_runtime_get_sync(&pdev->dev);\n" ">>\n" ">> ...this get doesn't happen, and the first register access causes a crash.\n" ">\n" @@ -64,10 +55,6 @@ "Driver code should not make assumptions like this about what device init\n" "code is or isn't doing.\n" "\n" - "Kevin\n" - "--\n" - "To unsubscribe from this list: send the line \"unsubscribe linux-omap\" in\n" - "the body of a message to majordomo@vger.kernel.org\n" - More majordomo info at http://vger.kernel.org/majordomo-info.html + Kevin -997c84ef9299fe284e117a9219225470075d410f8784ec6df1fdb62ae296667f +167e9b984808e9d554940b627c50a9849fa07346ddae4ee887aa66be57d1aa8a
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.