From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Subject: Re: [PATCH 01/19] quota: protect getfmt call with dqonoff_mutex lock Date: Thu, 02 Dec 2010 14:40:26 +0300 Message-ID: <87oc94768l.fsf@dmon-lap.sw.ru> References: <1289477678-5669-1-git-send-email-dmonakhov@openvz.org> <1289477678-5669-2-git-send-email-dmonakhov@openvz.org> <20101122193502.GC6141@quack.suse.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-fsdevel@vger.kernel.org, jack@suse.cz, hch@infradead.org To: Jan Kara Return-path: Received: from mail-ey0-f174.google.com ([209.85.215.174]:64891 "EHLO mail-ey0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751633Ab0LBLkd (ORCPT ); Thu, 2 Dec 2010 06:40:33 -0500 Received: by eye27 with SMTP id 27so4140556eye.19 for ; Thu, 02 Dec 2010 03:40:32 -0800 (PST) In-Reply-To: <20101122193502.GC6141@quack.suse.cz> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Mon, 22 Nov 2010 20:35:02 +0100, Jan Kara wrote: > On Thu 11-11-10 15:14:20, Dmitry Monakhov wrote: > > dqptr_sem hasn't any thing in common with quota files, > > quota file load protected with dqonoff_mutex, so we have to use > > it for reading fmt info. > You missed ext2 and jfs from the conversion. Also you should mention that Hm... i've recheck that and it appears you are not right here. ext2,jfs2 use default quota operations dquot_quotactl_ops; And this patch added ->get_fmt call to default ops. > you introduce new ->get_fmt call. Other than that just one nitpick: > > > diff --git a/include/linux/quota.h b/include/linux/quota.h > > index 9a85412..2767e4c 100644 > > --- a/include/linux/quota.h > > +++ b/include/linux/quota.h > > @@ -331,6 +331,7 @@ struct quotactl_ops { > > int (*quota_off)(struct super_block *, int); > > int (*quota_sync)(struct super_block *, int, int); > > int (*get_info)(struct super_block *, int, struct if_dqinfo *); > > + int (*get_fmt)(struct super_block*, int, unsigned int*); > ^ space before * > > Honza > -- > Jan Kara > SUSE Labs, CR