From: Arnaud Patard (Rtp) <arnaud.patard@rtp-net.org>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: alsa-devel@alsa-project.org, Liam Girdwood <lrg@slimlogic.co.uk>,
Saeed Bishara <saeed@marvell.com>,
Martin Michlmayr <tbm@cyrius.com>
Subject: Re: [patch 3/3] t5325: add audio support
Date: Wed, 13 Oct 2010 20:25:12 +0200 [thread overview]
Message-ID: <87ocayvtkn.fsf@lechat.rtp-net.org> (raw)
In-Reply-To: <20101013180607.GA15001@sirena.org.uk> (Mark Brown's message of "Wed\, 13 Oct 2010 19\:06\:08 +0100")
Mark Brown <broonie@opensource.wolfsonmicro.com> writes:
> On Wed, Oct 13, 2010 at 08:01:44PM +0200, Arnaud Patard wrote:
>> Mark Brown <broonie@opensource.wolfsonmicro.com> writes:
>
>> > On Tue, Oct 12, 2010 at 11:44:56AM +0200, Arnaud Patard wrote:
>> >> This patch declares the i2c audio codec and initialise audio.
>
>> > Looks like the changelogs for this and the previous patch got
>> > transposed
>
>> It's bad wording then. For me the changelog is fine. It means that :
>
>> - it's adding the alc5621 codec in the i2c bard info
>> - initialise kirkwood audio stuff by calling kirkwood_audio_init().
>
>> Maybe putting the explanations above would be better ?
>
> Oh, actually the problem is that you've not prefixed the ASoC patches
> with ASoC: so they look like they're supposed to be arch/arm patches
> (2/3 being the main offender).
Oh, I see. This patch is modify arch/arm/mach-kirkwood/t5325-setup.c and
is adding only audio stuff and needs a header coming from previous
patches. That's why I've put it in the patch serie. imho doing like this
should make life easier for everyone.
Will add and "ASoC:" in the patch subject.
Thanks,
Arnaud
next prev parent reply other threads:[~2010-10-13 18:25 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-12 9:44 [patch 0/3] ALC562[123] / t5325 sound support - try 2 Arnaud Patard
2010-10-12 9:44 ` [patch 1/3] ASoC: add support for alc562[123] codecs Arnaud Patard
2010-10-12 17:16 ` Mark Brown
2010-10-13 17:58 ` Arnaud Patard
2010-10-13 18:03 ` Mark Brown
2010-10-13 18:22 ` Arnaud Patard
2010-10-12 9:44 ` [patch 2/3] kirkwood: Add audio support to hp t5325 thin clients Arnaud Patard
2010-10-12 17:17 ` Mark Brown
2010-10-12 9:44 ` [patch 3/3] t5325: add audio support Arnaud Patard
2010-10-12 17:18 ` Mark Brown
2010-10-13 18:01 ` Arnaud Patard
2010-10-13 18:06 ` Mark Brown
2010-10-13 18:25 ` Arnaud Patard [this message]
2010-10-13 18:43 ` Mark Brown
-- strict thread matches above, loose matches on Subject: below --
2010-09-07 7:01 [patch 0/3] ASoC: t5325 " Arnaud Patard
2010-09-07 7:01 ` [patch 3/3] t5325: add " Arnaud Patard
2010-09-07 10:23 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ocayvtkn.fsf@lechat.rtp-net.org \
--to=arnaud.patard@rtp-net.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=lrg@slimlogic.co.uk \
--cc=saeed@marvell.com \
--cc=tbm@cyrius.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.