From: Kevin Hilman <khilman@deeprootsystems.com>
To: "Cousson, Benoit" <b-cousson@ti.com>
Cc: HEMA HK <hemahk@ti.com>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
Felipe Balbi <felipe.balbi@nokia.com>,
Tony Lindgren <tony@atomide.com>
Subject: Re: [PATCH 0/8]usb: musb:USB driver changes to use hwmod+ omap-device apis
Date: Mon, 09 Aug 2010 13:58:01 -0700 [thread overview]
Message-ID: <87ocdbijvq.fsf@deeprootsystems.com> (raw)
In-Reply-To: <4C5FF544.9050907@ti.com> (Benoit Cousson's message of "Mon, 09 Aug 2010 14:32:04 +0200")
"Cousson, Benoit" <b-cousson@ti.com> writes:
> On 8/6/2010 5:54 PM, HEMA HK wrote:
>> From: Hema HK<hemahk@ti.com>
>>
>> Series of patches to port musb driver to use hwmod and runtime pm
>> APIs for OMAP4 and OMAP3.These patches are tested on OMAP4430SDP and
>> OMAP3630-ZOOM3 boards.
>>
>> The patch 1 and 2 are are the prerequisites for the hwmod changes.
>> Patch 6 is the OMAP3 offmode support patch.
>>
>> This patch series is generated on "origin/pm-wip/hwmods-omap4".
>>
>> Offmode is tested with origin/pm on omap3630 zoom3 board.
>
> The way you are submitting that series is quite confusing!
>
> You are mixing several numbering schemes and several series versions.
> If this is a V2, you have to resubmit everything with a V2, and you
> must include an history.
>
> [8/8] usb : musb:Using runtime pm apis for musb.
> [7/8] : Hwmod api changes
> [V2,6/8] usb: musb: Offmode fix for idle path
> [V2,4/8] usb : musb:Using omap_device_build for musb device registration
> [4/8] usb: musb: HWMOD database structures fixes OMAP4
> [V2,3/4] usb: musb: HWMOD database structures addition for OMAP3
> [2/8] usb: musb: Remove board_data parameter from musb_platform_init()
> [1/8] usb: musb: Adding names for IRQs in resource structure
>
>
> The cover letter does not contain the overall stat to summarize what
> files you are modifying.
Please consider using git-format-patch + git-send-email which will
automatically take care of many of the problems Benoit has pointed out.
Please see this wiki page for lots of useful suggestions:
http://wiki.omappedia.org/wiki/Releasing_to_Linux_kernel_using_patches_and_emails
Kevin
next prev parent reply other threads:[~2010-08-09 20:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-06 15:54 [PATCH 0/8]usb: musb:USB driver changes to use hwmod+ omap-device apis HEMA HK
[not found] ` <1281110052-28990-1-git-send-email-hemahk-l0cyMroinI0@public.gmane.org>
2010-08-09 12:32 ` Cousson, Benoit
2010-08-09 20:58 ` Kevin Hilman [this message]
2010-08-10 5:03 ` Kalliguddi, Hema
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ocdbijvq.fsf@deeprootsystems.com \
--to=khilman@deeprootsystems.com \
--cc=b-cousson@ti.com \
--cc=felipe.balbi@nokia.com \
--cc=hemahk@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.