From: Sven Joachim <svenjoac@gmx.de>
To: dri-devel@lists.freedesktop.org
Cc: Adam Jackson <ajax@redhat.com>, Dave Airlie <airlied@redhat.com>,
linux-kernel@vger.kernel.org
Subject: drm: refresh rate down to 60 Hz in 2.6.35-rc5
Date: Wed, 14 Jul 2010 21:09:33 +0200 [thread overview]
Message-ID: <87oce9khhu.fsf@turtle.gmx.de> (raw)
[ Resending to the right mailing list. I looked up in MAINTAINERS, but
forgot to run "git bisect reset" and got the wrong address for
dri-devel@. Apologies to all who receive this twice. ]
After upgrading to 2.6.35-rc5, I noticed that my monitor reports a
refresh rate of 60 Hz when nouveau.ko is loaded, rather than the 75 Hz I
got on 2.6.34. Graphics card is an NV86 (GeForce 8500 GT), the monitor
is a 1280x1024 TFT (Yakumo 19AL) connected via VGA.
I bisected this to the following commit:
--8<---------------cut here---------------start------------->8---
commit c867df7043b738da4f4d358d7039c243a29b4272
Author: Adam Jackson <ajax@redhat.com>
Date: Mon Mar 29 21:43:21 2010 +0000
drm/edid: Reshuffle mode list construction to closer match the spec
Also, document what the spec says to do.
Signed-off-by: Adam Jackson <ajax@redhat.com>
Signed-off-by: Dave Airlie <airlied@redhat.com>
diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
index 9c4717f..858fedc 100644
--- a/drivers/gpu/drm/drm_edid.c
+++ b/drivers/gpu/drm/drm_edid.c
@@ -1377,10 +1377,24 @@ int drm_add_edid_modes(struct drm_connector *connector, struct edid *edid)
quirks = edid_get_quirks(edid);
- num_modes += add_established_modes(connector, edid);
- num_modes += add_standard_modes(connector, edid);
+ /*
+ * EDID spec says modes should be preferred in this order:
+ * - preferred detailed mode
+ * - other detailed modes from base block
+ * - detailed modes from extension blocks
+ * - CVT 3-byte code modes
+ * - standard timing codes
+ * - established timing codes
+ * - modes inferred from GTF or CVT range information
+ *
+ * We don't quite implement this yet, but we're close.
+ *
+ * XXX order for additional mode types in extension blocks?
+ */
num_modes += add_detailed_info(connector, edid, quirks);
num_modes += add_detailed_info_eedid(connector, edid, quirks);
+ num_modes += add_standard_modes(connector, edid);
+ num_modes += add_established_modes(connector, edid);
if (quirks & (EDID_QUIRK_PREFER_LARGE_60 | EDID_QUIRK_PREFER_LARGE_75))
edid_fixup_preferred(connector, quirks);
--8<---------------cut here---------------end--------------->8---
How do I get the 75 Hz refresh rate back? Adding "video=1280x1024@75"
as described in the nouveau wiki¹ has no effect.
Regards,
Sven
¹ http://nouveau.freedesktop.org/wiki/KernelModeSetting
next reply other threads:[~2010-07-14 19:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-14 19:09 Sven Joachim [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-07-14 18:39 drm: refresh rate down to 60 Hz in 2.6.35-rc5 Sven Joachim
2010-07-14 18:39 Sven Joachim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87oce9khhu.fsf@turtle.gmx.de \
--to=svenjoac@gmx.de \
--cc=airlied@redhat.com \
--cc=ajax@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.