Re: [PATCH 1/1] hid-magicmouse: Fix oops after device removal.

[Michael Poole <mdpoole@troilus.org>]

Dmitry Torokhov writes:

>>  static void magicmouse_remove(struct hid_device *hdev)
>>  {
>> +	struct magicmouse_sc *msc;
>
> Blank lines between variable definitions and code are always
> appreciated. but also coudl be written as:
>
> 	struct magicmouse_sc *msc = hid_get_drvdata(dev);
>
>> +	msc = hid_get_drvdata(hdev);
>>  	hid_hw_stop(hdev);
>> +	input_unregister_device(msc->input);
>>  	kfree(hid_get_drvdata(hdev));
>
> You have msc already sho that should be 'kfree(msc);'.

I'll fix both of these and resubmit.  Thanks for the review.

Michael