From: Kevin Hilman <khilman@deeprootsystems.com>
To: Paul Walmsley <paul@pwsan.com>
Cc: linux-omap@vger.kernel.org
Subject: Re: [PATCH 2/3] OMAP: hwmod: add read/write API for SYSCONFIG
Date: Thu, 14 Jan 2010 10:07:34 -0800 [thread overview]
Message-ID: <87ockwa7bt.fsf@deeprootsystems.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1001131822440.4769@utopia.booyaka.com> (Paul Walmsley's message of "Wed\, 13 Jan 2010 18\:26\:04 -0700 \(MST\)")
Paul Walmsley <paul@pwsan.com> writes:
> Hi Kevin,
>
> On Fri, 8 Jan 2010, Kevin Hilman wrote:
>
>> Some HW blocks have errata which requires selective enabling/disabling
>> of SYSCONFIG bits. In particular, some blocks have known issues with
>> smart-idle so smart-idle has to be disabled under certain conditions.
>
> ...
>
>> RFC: would an API to only touch smart-idle be more appropriate? Maybe
>> omap_hwmod_smart_idle_enable(oh, bool enable)?
>
> This idea sounds good. Since the SYSCONFIG bit fields can change and move
> around depending on the chip and IP, some type of higher-level API seems
> necessary to preserve sanity.
>
> Maybe omap_hwmod_smart_idle_enable() and omap_hwmod_smart_idle_disable(),
> mimicking API styles like clk_enable()/clk_disable(), etc.? Care to spin
> something like that?
Sounds good, Coming right up....
Kevin
next prev parent reply other threads:[~2010-01-14 18:15 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-08 23:26 [PATCH 0/3] misc. omap_device/omap_hwmod updates Kevin Hilman
2010-01-08 23:26 ` [PATCH 1/3] OMAP: omap_device: optionally auto-adjust device activate/deactivate latencies Kevin Hilman
2010-01-08 23:26 ` [PATCH 2/3] OMAP: hwmod: add read/write API for SYSCONFIG Kevin Hilman
2010-01-08 23:26 ` [PATCH 3/3] OMAP: hwmod: allow idle after HWMOD_INIT_NO_IDLE Kevin Hilman
2010-01-14 0:53 ` Kevin Hilman
2010-01-14 1:26 ` [PATCH 2/3] OMAP: hwmod: add read/write API for SYSCONFIG Paul Walmsley
2010-01-14 18:07 ` Kevin Hilman [this message]
2010-01-15 0:19 ` Kevin Hilman
2010-01-15 17:08 ` Paul Walmsley
2010-01-09 15:04 ` [PATCH 1/3] OMAP: omap_device: optionally auto-adjust device activate/deactivate latencies Nishanth Menon
2010-01-12 0:50 ` Kevin Hilman
2010-01-12 1:01 ` Nishanth Menon
2010-01-12 1:07 ` Kevin Hilman
2010-01-14 1:05 ` Paul Walmsley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ockwa7bt.fsf@deeprootsystems.com \
--to=khilman@deeprootsystems.com \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.