All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Hilman <khilman@deeprootsystems.com>
To: Tero Kristo <tero.kristo@nokia.com>
Cc: linux-omap@vger.kernel.org
Subject: Re: [PATCH 0/6] Idle status patches revisited
Date: Mon, 16 Nov 2009 11:30:45 -0800	[thread overview]
Message-ID: <87ocn2jmhm.fsf@deeprootsystems.com> (raw)
In-Reply-To: <1258045359-7962-1-git-send-email-tero.kristo@nokia.com> (Tero Kristo's message of "Thu\, 12 Nov 2009 19\:02\:33 +0200")

Tero Kristo <tero.kristo@nokia.com> writes:

> From: Tero Kristo <tero.kristo@nokia.com>
>
> Following set implements checks for idle states of powerdomains, and
> changes target cpuidle state according to those. This also includes as
> a cleanup removal of some hacks from omap_sram_idle(), and also introduces
> INACTIVE / ON state support for powerdomains which simplifies the code.
>
> Applies on top of PM branch.

Hi Tero,

I *really* like this cleanup and re-organization you've done.  I have
a few minor comments on some of the patches, but overall it looks
really good.

I'll wait for Paul's comments/signoff on PATCH 1/6, and after some of
my comments are addressed, I'll gladly pull an updated series into the
PM branch.

Kevin

      parent reply	other threads:[~2009-11-16 19:30 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-12 17:02 [PATCH 0/6] Idle status patches revisited Tero Kristo
2009-11-12 17:02 ` [PATCH 1/6] OMAP: Powerdomains: Add support for INACTIVE state on pwrdm level Tero Kristo
2009-11-12 17:02   ` [PATCH 2/6] OMAP3: PM: Added support for INACTIVE and ON states for powerdomains Tero Kristo
2009-11-12 17:02     ` [PATCH 3/6] OMAP3: CPUidle: Fixed support for ON / INACTIVE states Tero Kristo
2009-11-12 17:02       ` [PATCH 4/6] OMAP3: PM: Removed PER + CORE state hacking from omap_sram_idle Tero Kristo
2009-11-12 17:02         ` [PATCH 5/6] OMAP: Powerdomains: Add support for checking if pwrdm can idle Tero Kristo
2009-11-12 17:02           ` [PATCH 6/6] OMAP3: CPUidle: Added peripheral pwrdm checks into bm check Tero Kristo
2009-11-16 19:58             ` Kevin Hilman
2009-11-17 11:12               ` Tero.Kristo
2009-11-16 20:13           ` [PATCH 5/6] OMAP: Powerdomains: Add support for checking if pwrdm can idle Kevin Hilman
2009-11-17 11:33             ` Tero.Kristo
2009-11-16 19:45         ` [PATCH 4/6] OMAP3: PM: Removed PER + CORE state hacking from omap_sram_idle Kevin Hilman
2009-11-17 11:08           ` Tero.Kristo
2009-11-16 19:42     ` [PATCH 2/6] OMAP3: PM: Added support for INACTIVE and ON states for powerdomains Kevin Hilman
2009-11-17 11:07       ` Tero.Kristo
2009-11-16 19:30 ` Kevin Hilman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ocn2jmhm.fsf@deeprootsystems.com \
    --to=khilman@deeprootsystems.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=tero.kristo@nokia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.