All of lore.kernel.org
 help / color / mirror / Atom feed
From: Petr Rockai <prockai@redhat.com>
To: lvm-devel@redhat.com
Subject: [PATCH] unknown segment types, part 1
Date: Thu, 09 Jul 2009 21:50:12 +0200	[thread overview]
Message-ID: <87ocrt8wln.fsf@twilight.int.mornfall.net.> (raw)
In-Reply-To: <4A562E89.5020601@redhat.com> (Milan Broz's message of "Thu, 09 Jul 2009 19:53:13 +0200")

Milan Broz <mbroz@redhat.com> writes:
> Actually only comments and some fancy formatting is lost. Is that correct?

Yes. We lose those because they are not parsed at all, so we cannot quite
reproduce them. Editing the metadata with LVM that understands the segment type
will restore the fancy comments and formatting (since these are hard-coded in
the export code for any given segment).

See also the testcase: doing a restore/backup cycle will restore the
(formatting-lost) volume group to exactly the same state as before.

Yours,
   Petr.



  reply	other threads:[~2009-07-09 19:50 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-08  9:18 [PATCH] unknown segment types, part 1 Petr Rockai
2009-07-09 17:27 ` Milan Broz
2009-07-09 17:53   ` Milan Broz
2009-07-09 19:50     ` Petr Rockai [this message]
2009-07-09 19:54   ` Petr Rockai
2009-07-09 20:11     ` Milan Broz
2009-07-21 14:41       ` [PATCH, v2] unknown segment types Petr Rockai
2009-09-29 14:42         ` Petr Rockai
2009-10-07 20:03           ` Dave Wysochanski
2009-10-07 20:53           ` [PATCH, v3] " Petr Rockai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ocrt8wln.fsf@twilight.int.mornfall.net. \
    --to=prockai@redhat.com \
    --cc=lvm-devel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.