All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] Updating toolchain config options to help external toolchain support.
Date: Thu, 29 Jan 2009 18:03:00 +0100	[thread overview]
Message-ID: <87ocxqqc3f.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <C13DBBE85AD6974B85C118C35890CA5F1AF39BD968@EU1RDCRDC1WX029.exi.nxp.com> (Daniel James Laird's message of "Wed\, 28 Jan 2009 12\:52\:56 +0100")

>>>>> "Daniel" == Daniel James Laird <daniel.j.laird@nxp.com> writes:

Hi,

 Daniel> After a lot a playing around I have made some changes to the
 Daniel> toolchain configuration options.  This now allows users of
 Daniel> external binary toolchains to enable/disable the same set of
 Daniel> features as those who are building a toolchain using
 Daniel> buildroot or external source.  However the number of changes
 Daniel> mean that I would like to post the patch below for comments
 Daniel> before commiting it.  I have tested the external toolchain
 Daniel> support side of things and checked the options are all ok but
 Daniel> I have not built a new buildroot toolchain (never done this)
 Daniel> perhaps someone can comment on patch below: If not I would
 Daniel> like to commit by friday to enable a few days testing before
 Daniel> final release.

It seems to work here - A few comments:

The reshuffle of configuration settings makes it fairly hard to find
stuff for existing users - I wonder if this is all worth it as these
things don't change very often.

 Daniel> +config BR2_ENABLE_LOCALE
 Daniel> +	bool "Toolchain built with locale/gettext/i18n support?"

The text used to be 'Enable locale/gettext/i18n support?', why the change?

 Daniel> ===================================================================
 Daniel> --- package/qte/Config.in	(revision 25087)
 Daniel> +++ package/qte/Config.in	(working copy)
 Daniel> @@ -2,7 +2,7 @@
 Daniel>  	bool "Qt/E"
 Daniel>  	depends on BR2_DEPRECATED
 Daniel>  	depends on BR2_INSTALL_LIBSTDCPP
 Daniel> -	select BR2_PTHREADS_NATIVE
 Daniel> +	depends on BR2_PTHREADS_NATIVE

This should go in a seperate commit, and have a comment entry like for
the other packages depending on toolchain config.

-- 
Bye, Peter Korsgaard

  parent reply	other threads:[~2009-01-29 17:03 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-28 11:52 [Buildroot] Updating toolchain config options to help external toolchain support Daniel James Laird
2009-01-29 13:50 ` Daniel Laird
2009-01-29 13:53   ` Peter Korsgaard
2009-01-29 18:12   ` Ulf Samuelsson
2009-01-29 18:48     ` Daniel Laird
2009-01-29 17:03 ` Peter Korsgaard [this message]
2009-01-30 14:26   ` Daniel Laird

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ocxqqc3f.fsf@macbook.be.48ers.dk \
    --to=jacmet@uclibc.org \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.