All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] svn commit: trunk/buildroot/package/liboil
Date: Sun, 25 Jan 2009 15:26:14 +0100	[thread overview]
Message-ID: <87ocxvfomx.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <20090125081654.4A59076D28@busybox.osuosl.org> (ulf@uclibc.org's message of "Sun\, 25 Jan 2009 08\:16\:54 +0000 \(UTC\)")

>>>>> "ulf" == ulf  <ulf@uclibc.org> writes:

 ulf> Author: ulf
 ulf> Date: 2009-01-25 08:16:53 +0000 (Sun, 25 Jan 2009)
 ulf> New Revision: 25012

 ulf> Log:
 ulf> liboil make fails on ARM with release toolset for a few unneeded examples due to use of hidden __clz_tab, do not build them for now, but problem may need further examination

 ulf> Modified:
 ulf>    trunk/buildroot/package/liboil/liboil.mk


 ulf> Changeset:
 ulf> Modified: trunk/buildroot/package/liboil/liboil.mk
 ulf> ===================================================================
 ulf> --- trunk/buildroot/package/liboil/liboil.mk	2009-01-25 08:14:37 UTC (rev 25011)
 ulf> +++ trunk/buildroot/package/liboil/liboil.mk	2009-01-25 08:16:53 UTC (rev 25012)
 ulf> @@ -26,6 +26,8 @@
 ulf>  LIBOIL_CONF_ENV = as_cv_unaligned_access=yes
 ulf>  endif
 
 ulf> +LIBOIL_CONF_OPT+=--with-gnu-ld
 ulf> +

Why? You don't mention anything about this in your commit message.

 ulf> +
 ulf> +$(LIBOIL_HOOK_POST_CONFIGURE):
 ulf> +	$(SED) 's/uberopt//g' $(LIBOIL_DIR)/examples/Makefile
 ulf> +	$(SED) 's/work//g' $(LIBOIL_DIR)/examples/Makefile

Why not disable all examples?

A comment like

# disable examples

Just above would be nice.

-- 
Bye, Peter Korsgaard

  reply	other threads:[~2009-01-25 14:26 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-25  8:16 [Buildroot] svn commit: trunk/buildroot/package/liboil ulf at uclibc.org
2009-01-25 14:26 ` Peter Korsgaard [this message]
  -- strict thread matches above, loose matches on Subject: below --
2009-01-25 23:47 ulf at uclibc.org
2009-01-26  6:04 ` Peter Korsgaard
2009-01-26 14:49 jacmet at uclibc.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ocxvfomx.fsf@macbook.be.48ers.dk \
    --to=jacmet@uclibc.org \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.