From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mx3.redhat.com (mx3.redhat.com [172.16.48.32]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id m729WcTP016351 for ; Sat, 2 Aug 2008 05:32:38 -0400 Received: from smtp3-g19.free.fr (smtp3-g19.free.fr [212.27.42.29]) by mx3.redhat.com (8.13.8/8.13.8) with ESMTP id m729WPT7028180 for ; Sat, 2 Aug 2008 05:32:25 -0400 To: Guennadi Liakhovetski References: <87tze4cr3g.fsf@free.fr> <1217629566-26637-1-git-send-email-robert.jarzmik@free.fr> <1217629566-26637-2-git-send-email-robert.jarzmik@free.fr> From: Robert Jarzmik Date: Sat, 02 Aug 2008 11:32:23 +0200 In-Reply-To: (Guennadi Liakhovetski's message of "Sat\, 2 Aug 2008 01\:31\:05 +0200 \(CEST\)") Message-ID: <87od4b69ug.fsf@free.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: video4linux-list@redhat.com Subject: Re: [PATCH] Fix suspend/resume of pxa_camera driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: video4linux-list-bounces@redhat.com Errors-To: video4linux-list-bounces@redhat.com List-ID: Guennadi Liakhovetski writes: > On Sat, 2 Aug 2008, Robert Jarzmik wrote: > >> PXA suspend switches off DMA core, which loses all context >> of previously assigned descriptors. As pxa_camera driver >> relies on DMA transfers, setup the lost descriptors on >> resume and retrigger frame acquisition if needed. >> >> Signed-off-by: Robert Jarzmik > > _Conditionally_ applied: I changed the subject to "Add suspend/resume > to...", upgraded to the current Linus' top-of-tree, and, most importantly, > changed this: OK. >> + if ((pcdev->icd) && (pcdev->icd->ops->resume)) >> + ret = pcdev->icd->ops->resume(pcdev->icd); > > To > > > Which I assume was a typo. Please, test these patches with this my change, > and confirm they are ok now. I'll push both of them upstream then. To be exact: wrong copy/paste. I'm sorry not have spotted this, I have no suspend function in mt9m111, I only used the resume one to restore the state ... And the two lines should be : + if ((pcdev->icd) && (pcdev->icd->ops->suspend)) + ret = pcdev->icd->ops->suspend(pcdev->icd, state); ^ compile error without Apart from that, I tested, and it's OK. Do you have an exported git tree I can sync with ? -- Robert -- video4linux-list mailing list Unsubscribe mailto:video4linux-list-request@redhat.com?subject=unsubscribe https://www.redhat.com/mailman/listinfo/video4linux-list