From: Ben Pfaff <blp@cs.stanford.edu>
To: linux-kernel@vger.kernel.org
Cc: linux-mm@kvack.org
Subject: Re: [patch 2/9] Store max number of objects in the page struct.
Date: Fri, 21 Mar 2008 20:27:31 -0700 [thread overview]
Message-ID: <87od975tgc.fsf@blp.benpfaff.org> (raw)
In-Reply-To: 20080321152407.b0fbe81f.akpm@linux-foundation.org
Andrew Morton <akpm@linux-foundation.org> writes:
>> +#define USHRT_MAX ((u16)(~0U))
>> +#define SHRT_MAX ((s16)(USHRT_MAX>>1))
>> +#define SHRT_MIN (-SHRT_MAX - 1)
>
> We have UINT_MAX and ULONG_MAX and ULLONG_MAX. If these were actually
> UNT_MAX, ULNG_MAX and ULLNG_MAX then USHRT_MAX would make sense.
>
> But they aren't, so it doesn't ;)
>
> Please, let's call them USHORT_MAX, SHORT_MAX and SHORT_MIN.
SHRT_MIN, SHRT_MAX, and USHRT_MAX are the spellings used by
<limits.h> required in ISO-conforming C implementations. That
doesn't mean that the kernel has to use those spellings, but it
does mean that those names are widely understood by C
programmers.
--
Ben Pfaff
http://benpfaff.org
WARNING: multiple messages have this Message-ID (diff)
From: Ben Pfaff <blp@cs.stanford.edu>
To: linux-mm@kvack.org
Cc: linux-kernel@vger.kernel.org
Subject: Re: [patch 2/9] Store max number of objects in the page struct.
Date: Fri, 21 Mar 2008 20:27:31 -0700 [thread overview]
Message-ID: <87od975tgc.fsf@blp.benpfaff.org> (raw)
In-Reply-To: 20080321152407.b0fbe81f.akpm@linux-foundation.org
Andrew Morton <akpm@linux-foundation.org> writes:
>> +#define USHRT_MAX ((u16)(~0U))
>> +#define SHRT_MAX ((s16)(USHRT_MAX>>1))
>> +#define SHRT_MIN (-SHRT_MAX - 1)
>
> We have UINT_MAX and ULONG_MAX and ULLONG_MAX. If these were actually
> UNT_MAX, ULNG_MAX and ULLNG_MAX then USHRT_MAX would make sense.
>
> But they aren't, so it doesn't ;)
>
> Please, let's call them USHORT_MAX, SHORT_MAX and SHORT_MIN.
SHRT_MIN, SHRT_MAX, and USHRT_MAX are the spellings used by
<limits.h> required in ISO-conforming C implementations. That
doesn't mean that the kernel has to use those spellings, but it
does mean that those names are widely understood by C
programmers.
--
Ben Pfaff
http://benpfaff.org
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-03-22 3:27 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20080317230516.078358225@sgi.com>
[not found] ` <20080317230529.474353536@sgi.com>
2008-03-18 18:54 ` [patch 7/9] slub: Adjust order boundaries and minimum objects per slab Pekka Enberg
2008-03-18 19:00 ` Christoph Lameter
2008-03-19 1:04 ` Zhang, Yanmin
2008-03-19 15:20 ` Pekka Enberg
2008-03-20 6:44 ` Zhang, Yanmin
2008-03-20 18:32 ` Christoph Lameter
[not found] ` <20080317230528.279983034@sgi.com>
2008-03-19 9:09 ` [patch 2/9] Store max number of objects in the page struct Zhang, Yanmin
2008-03-19 17:49 ` Christoph Lameter
2008-03-20 3:32 ` Zhang, Yanmin
2008-03-20 3:32 ` Zhang, Yanmin
2008-03-20 21:05 ` Christoph Lameter
2008-03-20 21:05 ` Christoph Lameter
2008-03-21 22:24 ` Andrew Morton
2008-03-21 22:24 ` Andrew Morton
2008-03-22 3:27 ` Ben Pfaff [this message]
2008-03-22 3:27 ` Ben Pfaff
2008-03-24 1:22 ` [PATCH] Add definitions of USHORT_MAX and others Zhang, Yanmin
2008-03-24 1:22 ` Zhang, Yanmin
[not found] ` <20080317230528.939792410@sgi.com>
2008-03-20 5:10 ` [patch 5/9] slub: Fallback to minimal order during slab page allocation Zhang, Yanmin
2008-03-20 18:29 ` Christoph Lameter
2008-03-21 0:52 ` Zhang, Yanmin
2008-03-21 3:35 ` Christoph Lameter
2008-03-21 5:14 ` Zhang, Yanmin
2008-03-21 6:07 ` Christoph Lameter
2008-03-21 8:23 ` Zhang, Yanmin
[not found] ` <20080317230529.701336582@sgi.com>
2008-03-20 5:53 ` [patch 8/9] slub: Make the order configurable for each slab cache Zhang, Yanmin
2008-03-20 18:31 ` Christoph Lameter
2008-03-20 23:57 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87od975tgc.fsf@blp.benpfaff.org \
--to=blp@cs.stanford.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.