Re: /kern/file.c BUG

[Marco Gerards <mgerards@xs4all.nl>]

Vesa Jääskeläinen <chaac@nic.fi> writes:

(replying to this mail, I didn't receive the first mail over the list...)

> Robert Millan wrote:
>> On Wed, Jan 23, 2008 at 11:00:57PM +0000, Oleg Strikov wrote:
>>> Incorrect behavior of grub_file_open () function in e.g. loop context:
>>>
>>> char *file_names[] =
>>> {
>>> "(hd0,1)/file1", //file do not exist
>>> "(hd0,1)/file2"  //file exist
>>> };
>>> grub_file_t file;
>>> int i;
>>> for (i = 0; i < 2; i++)
>>> {
>>>      file  = grub_file_open (file_names[i]);
>>>      if (file) {...}
>>> }
>>>
>>> There, we should get positive return in the second case (i == 1), but
>>> grub_file_open() returns 0.

No, that is not right.  This behavior is correct.

When you open the first file, you get an error which you ignore.  If
you think this error is harmless, clear it.  So your code is wrong.

--
Marco