From mboxrd@z Thu Jan  1 00:00:00 1970
From: Otavio Salvador <otavio@ossystems.com.br>
Subject: Re: Re: [PATCH] Enable Core 2 Duo PerformanceCounters
	inHVM guest
Date: Fri, 14 Dec 2007 17:05:27 -0200
Message-ID: <87odct14i0.fsf@lab.ossystems.com.br>
References: <823A93EED437D048963A3697DB0E35DEF7A8E9@pdsmsx414.ccr.corp.intel.com>
	<C3880369.19D1A%Keir.Fraser@cl.cam.ac.uk>
	<823A93EED437D048963A3697DB0E35DEF7A949@pdsmsx414.ccr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <823A93EED437D048963A3697DB0E35DEF7A949@pdsmsx414.ccr.corp.intel.com>
	(Haitao Shan's message of "Fri\, 14 Dec 2007 23\:43\:48 +0800")
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: "Shan, Haitao" <haitao.shan@intel.com>
Cc: xen-devel@lists.xensource.com, "Jiang, Yunhong" <yunhong.jiang@intel.com>
List-Id: xen-devel@lists.xenproject.org

"Shan, Haitao" <haitao.shan@intel.com> writes:

Hello Haitao,

I've done a look on the patch and found two places with wrong coding
style. Take a look bellow:

> diff -r 8f0cbfc478d6 xen/arch/x86/oprofile/op_model_ppro.c
> --- a/xen/arch/x86/oprofile/op_model_ppro.c	Thu Dec 13 09:31:03 2007 +0000
> +++ b/xen/arch/x86/oprofile/op_model_ppro.c	Fri Dec 14 07:21:43 2007 +0800
> @@ -126,6 +127,11 @@ static void ppro_start(struct op_msrs co
>  	CTRL_READ(low, high, msrs, 0);
>  	CTRL_SET_ACTIVE(low);
>  	CTRL_WRITE(low, high, msrs, 0);
> +    /* Global Control MSR is enabled by default when system power on.
> +     * However, this may not hold true when xenoprof starts to run.
> +     */
> +    if ( ppro_has_global_ctrl )
> +        wrmsrl(MSR_CORE_PERF_GLOBAL_CTRL, 1);
>  }
>  
>  
> @@ -135,6 +141,8 @@ static void ppro_stop(struct op_msrs con
>  	CTRL_READ(low, high, msrs, 0);
>  	CTRL_SET_INACTIVE(low);
>  	CTRL_WRITE(low, high, msrs, 0);
> +    if ( ppro_has_global_ctrl )
> +        wrmsrl(MSR_CORE_PERF_GLOBAL_CTRL, 0);
>  }

Cheers,

-- 
Otavio Salvador                  O.S. Systems
E-mail: otavio@ossystems.com.br  http://www.ossystems.com.br
Mobile: +55 53 9981-7854         http://projetos.ossystems.com.br