From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1Dsjgh-0000hp-NC for mharc-grub-devel@gnu.org; Wed, 13 Jul 2005 12:02:19 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Dsjgc-0000fJ-ID for grub-devel@gnu.org; Wed, 13 Jul 2005 12:02:15 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1DsjgY-0000dD-0d for grub-devel@gnu.org; Wed, 13 Jul 2005 12:02:10 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DsjgX-0000cn-KS for grub-devel@gnu.org; Wed, 13 Jul 2005 12:02:09 -0400 Received: from [145.74.66.11] (helo=mail-cn.han.nl) by monty-python.gnu.org with esmtp (Exim 4.34) id 1DsjmF-0000Hr-Ra for grub-devel@gnu.org; Wed, 13 Jul 2005 12:08:04 -0400 Received: from vscan-cn.han.nl (venus.han.nl [145.74.65.6]) by mail-cn.han.nl (Postfix) with ESMTP id 013E38B91 for ; Wed, 13 Jul 2005 17:59:55 +0200 (CEST) Received: from mail-cn.han.nl ([145.74.66.11]) by vscan-cn.han.nl (venus.han.nl [145.74.65.6]) (amavisd-new, port 10024) with ESMTP id 06240-05 for ; Wed, 13 Jul 2005 17:06:25 +0200 (CEST) Received: from mail1.han.nl (mail1.han.nl [145.74.103.11]) by mail-cn.han.nl (Postfix) with ESMTP id 25F7C85FB for ; Wed, 13 Jul 2005 17:59:53 +0200 (CEST) Received: from localhost.localdomain (mgerards.xs4all.nl [82.92.27.129]) by mail1.han.nl (Postfix) with ESMTP id E3218C046 for ; Wed, 13 Jul 2005 17:59:52 +0200 (CEST) Mail-Copies-To: metgerards@student.han.nl To: The development of GRUB 2 References: <42D26452.3010706@yahoo.fr> <200507121258.40668.okuji@enbug.org> <42D3B827.4090103@yahoo.fr> <87hdf0p4jy.fsf@student.han.nl> <42D3C877.3040607@yahoo.fr> <5b8d0feefaf6717dc015cc834de2da1b@penguinppc.org> <877jfwowlo.fsf@student.han.nl> <42D41013.4040601@yahoo.fr> <87y88bolt3.fsf@student.han.nl> <42D42CC1.80301@yahoo.fr> From: Marco Gerards Date: Wed, 13 Jul 2005 17:59:53 +0200 In-Reply-To: <42D42CC1.80301@yahoo.fr> (Vincent Pelletier's message of "Tue, 12 Jul 2005 22:49:05 +0200") Message-ID: <87oe96ae86.fsf@student.han.nl> User-Agent: Gnus/5.1007 (Gnus v5.10.7) Emacs/21.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Virus-Scanned: by amavisd-new (2.2.0) at vscan-cn.han.nl Subject: Re: sparc64 port : diffs to powerpc branches X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Jul 2005 16:02:16 -0000 Vincent Pelletier writes: > Marco Gerards wrote: >> This is an important test. Please do not remove it so this code can >> be shared. Just make sure GRUB_IEEE1275_FLAG_NO_PARTITION_0 is set or >> not set, depending on how OB works. > > No problem, I removed it to show that it isn't needed for usparc. Ok, but it should be restored for the final patch. >> Can this be done in a way that we can share most (all?) headers >> related to ieee 1275? > > I think so, except for some special function, like the term colour one > (I don't think usparc can change colour... Or at least not the same way > ppc does.) In that case the usparc port needs a GRUB_IEEE1275_FLAG_... to indicate it is not possible to change colors or that it works differently. >>>Changed some suspicious "&string" to just "string". > > Some function with void * arguments were actualy receiving char *[]. > There was no warning about it, but I think there was a leak. > I changed them to char * (dynamically allocated, see next remark :) ). It sounds ok to me. >>>Added malloc calls when size can be known. >> Nice! > > More can be done, I haven't done it everywhere. They should all be changed, but it is not that important for this port. It is something that should be done in general. >> Can you write the code so it works on both the PPC and sparc so this >> code can be shared? Some code you disabled like this has a function >> on the PPC, IIRC. > > I think that function works on usparc (not sure though) but as it is not > used at all, I commented it (to get some remarks about it so I can guess > what it's used for :) ). Ehm, ok, please ask specific questions if you have them. :) >>>Remove ppc specific partition numbering thing. >> Can you explain this? > > It seems that ppc numbers his partitions a special way (ruled by a flag, > so we can make it common to both if the flag is correctly set). Right. >> When you implement this, you can support switching from normal to >> rescue mode and back properly. > > There should be a bug in the x86 implementation, that would explain the > unaligned pointer I get when switching to rescue mode from normal mode. Perhaps... Can you put the bug report on the wiki so we will not forget about it? >> grub-mkimage is used to add modules to grubof. > > So this works, sun partition label & ext2 is read. You did not load ext2 as a module, but linked it into the binary. I assume you did not use grub-mkimage yet... >> Do you want me to fully review the complete patch or was it just a >> reference for your description? > > I think you shouldn't. Once the common parts will have been extracted a > real patch with changelog will be edited. Ok, cool. I am looking forwards to that patch. Thanks, Marco