From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1CxA64-0006hz-08 for mharc-grub-devel@gnu.org; Fri, 04 Feb 2005 15:30:32 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1CxA5v-0006fH-FZ for grub-devel@gnu.org; Fri, 04 Feb 2005 15:30:23 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1CxA5k-0006bM-R9 for grub-devel@gnu.org; Fri, 04 Feb 2005 15:30:16 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1CxA5h-0006Y8-88 for grub-devel@gnu.org; Fri, 04 Feb 2005 15:30:09 -0500 Received: from [145.74.66.11] (helo=mail-cn.han.nl) by monty-python.gnu.org with esmtp (Exim 4.34) id 1Cx9jV-0002S0-J6 for grub-devel@gnu.org; Fri, 04 Feb 2005 15:07:13 -0500 Received: from vscan-cn.han.nl (venus.han.nl [145.74.65.6]) by mail-cn.han.nl (Postfix) with ESMTP id 3F3CD8EE8 for ; Fri, 4 Feb 2005 21:04:41 +0100 (CET) Received: from mail-cn.han.nl ([145.74.66.11]) by vscan-cn.han.nl (venus.han.nl [145.74.65.6]) (amavisd-new, port 10024) with ESMTP id 26577-06 for ; Fri, 4 Feb 2005 21:04:38 +0100 (CET) Received: from mail1.han.nl (mail1.han.nl [145.74.103.11]) by mail-cn.han.nl (Postfix) with ESMTP id 51F379451 for ; Fri, 4 Feb 2005 21:04:38 +0100 (CET) Received: from marco.marco-g.com (mgerards.xs4all.nl [82.92.27.129]) by mail1.han.nl (Postfix) with ESMTP id 0D0ECC045 for ; Fri, 4 Feb 2005 21:04:38 +0100 (CET) Mail-Copies-To: metgerards@student.han.nl To: The development of GRUB 2 References: <20050204061115.GA20463@miracle> From: Marco Gerards Date: Fri, 04 Feb 2005 20:04:40 +0000 In-Reply-To: <20050204061115.GA20463@miracle> (Hollis Blanchard's message of "Fri, 4 Feb 2005 00:11:15 -0600") Message-ID: <87oef03xd3.fsf@marco.marco-g.com> User-Agent: Gnus/5.1006 (Gnus v5.10.6) Emacs/21.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Virus-Scanned: by amavisd-new (2.2.0) at vscan-cn.han.nl Subject: Re: iterate return values X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Feb 2005 20:30:27 -0000 Hollis Blanchard writes: > This one took waaay too long to track down. :( It is very difficult to > debug when the problem is that grub_errno has a stale value. > > This fixes my partition map problems, and has been tested both with > Apple and DOS partition maps. That's nice! There are a few comments. If you fixed those minor issues, feel free to commit the patch. > > -Hollis > > Index: ChangeLog > =================================================================== > RCS file: /cvsroot/grub/grub2/ChangeLog,v > retrieving revision 1.90 > diff -u -p -r1.90 ChangeLog > --- ChangeLog 1 Feb 2005 21:53:34 -0000 1.90 > +++ ChangeLog 4 Feb 2005 06:34:08 -0000 > @@ -1,3 +1,13 @@ > +2005-02-03 Hollis Blanchard The changelog is fine for me, but please don't send it in as a patch. > - > + > auto int part_map_probe (const grub_partition_map_t partmap); > - > + Please watch out for changes like these. > + if (err == GRUB_ERR_BAD_PART_TABLE) > + { > + /* Continue to next partition map type. */ > + grub_errno = GRUB_ERR_NONE; > + return 0; > + } This looks like a tab, please don't use tabs. I hope you can fix it if that is the case and the same for the rest of the patch, if the same happened there. Thanks, Marco