From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.33) id 1CUi53-0002nb-Pu for mharc-grub-devel@gnu.org; Thu, 18 Nov 2004 03:55:53 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1CUi51-0002nV-Cn for grub-devel@gnu.org; Thu, 18 Nov 2004 03:55:51 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1CUi50-0002nJ-5K for grub-devel@gnu.org; Thu, 18 Nov 2004 03:55:50 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1CUi4z-0002nG-Vm for grub-devel@gnu.org; Thu, 18 Nov 2004 03:55:50 -0500 Received: from [145.74.66.11] (helo=mail-cn.han.nl) by monty-python.gnu.org with esmtp (Exim 4.34) id 1CUhw7-0007zo-D6 for grub-devel@gnu.org; Thu, 18 Nov 2004 03:46:39 -0500 Received: from localhost (charlie.han.nl [145.74.66.9]) by mail-cn.han.nl (Postfix) with ESMTP id 98A72BBB8 for ; Thu, 18 Nov 2004 09:16:48 +0100 (CET) Received: from mail-cn.han.nl ([145.74.66.11]) by localhost (charlie.han.nl [145.74.66.9]) (amavisd-new, port 10024) with ESMTP id 12449-03 for ; Thu, 18 Nov 2004 09:16:47 +0100 (CET) Received: from mail1.han.nl (mail1.han.nl [145.74.103.11]) by mail-cn.han.nl (Postfix) with ESMTP id EA7AABBA8 for ; Thu, 18 Nov 2004 09:16:46 +0100 (CET) Received: from marco.marco-g.com (mgerards.xs4all.nl [82.92.27.129]) by mail1.han.nl (Postfix) with ESMTP id ABFA6C046 for ; Thu, 18 Nov 2004 09:16:46 +0100 (CET) Mail-Copies-To: metgerards@student.han.nl To: The development of GRUB 2 References: <87actg8ehq.fsf@marco.marco-g.com> From: Marco Gerards Date: Thu, 18 Nov 2004 08:16:54 +0000 In-Reply-To: (Hollis Blanchard's message of "Wed, 17 Nov 2004 21:50:30 -0600") Message-ID: <87oehv4lmx.fsf@marco.marco-g.com> User-Agent: Gnus/5.1006 (Gnus v5.10.6) Emacs/21.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Virus-Scanned: by amavisd-new@vscan-cn.han.nl Subject: Re: Partition modules X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Nov 2004 08:55:51 -0000 Hollis Blanchard writes: > I do have an objection here: members like "bsd_type" don't belong in a > generic struct, but rather in grub_partition_bsd_type. I believe > grub_partition should be the abstraction, i.e. what defines a > partition in the general sense. start, len, and index are obviously > good; offset is compensating for a DOS issue, though at least it has > (irrelevant) meaning for an Apple map... but ext_offset and these dos_ > and bsd_ things don't belong here IMHO. Ok. > Also, there were a number of whitespace-only lines in your patch; a > simple regex should show you where. Ok. > I'm seeing a crash on both briQ and my G3, so I'm sprinkling printfs > now... Does the PC partition map work on the briQ now? Thanks, Marco