All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Sreeraj S Kurup <sreekuttan2156239@gmail.com>
Cc: tiwai@suse.de, cezary.rojewski@intel.com,
	linux-kernel@vger.kernel.org, linux-sound@vger.kernel.org,
	perex@perex.cz, rosenp@gmail.com, tim.bird@sony.com,
	tiwai@suse.com
Subject: Re: [PATCH] ALSA: pcm: Fix source frame count calculation
Date: Mon, 02 Nov 2026 16:04:37 +0100	[thread overview]
Message-ID: <87pkwn8ebe.wl-tiwai@suse.de> (raw)
In-Reply-To: <20261102144736.3679-1-sreekuttan2156239@gmail.com>

On Mon, 02 Nov 2026 15:47:36 +0100,
Sreeraj S Kurup wrote:
> 
> You're right. I checked the callback implementation, and 
> "snd_pcm_plugin_client_channels()" always returns the input 
> frame count. All plugins created through "snd_pcm_plugin_build()" 
> use this callback.
> 
> So the condition "err != frames1" is not reached in the normal path. 
> My patch is unnecessary. Sorry for the noise.

Well, the logic you described looks still correct, so it's better to
correct the code even if it's only hypothetical.

So I applied your patch now with a bit more explanation.


thanks,

Takashi

  reply	other threads:[~2026-11-02 15:04 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-02 14:16 [PATCH] ALSA: pcm: Fix source frame count calculation Sreeraj S Kurup
2026-11-02 14:31 ` Takashi Iwai
2026-11-02 14:47   ` Sreeraj S Kurup
2026-11-02 15:04     ` Takashi Iwai [this message]
2026-11-02 15:40       ` Sreeraj S Kurup
2026-11-03 12:52       ` Sreeraj S Kurup
2026-11-03 14:42         ` Takashi Iwai
  -- strict thread matches above, loose matches on Subject: below --
2026-11-02 14:34 Sreeraj S Kurup

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pkwn8ebe.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=cezary.rojewski@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=rosenp@gmail.com \
    --cc=sreekuttan2156239@gmail.com \
    --cc=tim.bird@sony.com \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.