Re: [PATCH 1/2] include: Add virtio-blk request flag FUA definitions

[Cornelia Huck <cohuck@redhat.com>]

On Wed, Oct 21 2026, Kevin Wolf <kwolf@redhat.com> wrote:

> Am 21.10.2026 um 09:59 hat Cornelia Huck geschrieben:
>> On Wed, Oct 21 2026, Alberto Faria <afaria@redhat.com> wrote:
>> 
>> > Signed-off-by: Alberto Faria <afaria@redhat.com>
>> > ---
>> >  include/standard-headers/linux/virtio_blk.h | 13 +++++++++++--
>> >  1 file changed, 11 insertions(+), 2 deletions(-)
>> 
>> Maybe explicitly mark as *placeholder*, so it doesn't get merged
>> accidentally?
>
> What is the proper (or at least common) way to do this? Do we really
> have to wait for Linux to merge the guest driver side of virtio device
> changes before we can add the emulation in QEMU?

If we have some changes in the synced-from-Linux headers, we really need
to do a proper header sync to get them (or the next sync might remove
the changes again...) So yes, this unfortunately needs to wait for a
kernel with the changes (can be -rc)...

***

The other question (not really related to this patch set, maybe
warranting a separate discussion): Should we move the host <-> guest
interface definition to a third place that both Linux and QEMU (and any
other piece of software) can sync from? Source-of-truth is the virtio
spec, so in a perfect world QEMU should not have to wait for a Linux
kernel with the definitions to be released once it has been enshrined
there. Grabbing everything from Linux is something that did get the job
done and avoided duplicating code, but maybe it's time to revisit this.
(We obviously should keep syncing headers for actual kernel <->
userspace interfaces.)