From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ECC1CC44507 for ; Wed, 15 Jul 2026 20:34:30 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7B32E10E4FA; Wed, 15 Jul 2026 20:34:30 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="HtwoRYQx"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.14]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2C75410E246 for ; Wed, 15 Jul 2026 20:34:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1784147640; x=1815683640; h=date:message-id:from:to:subject:in-reply-to:references: mime-version; bh=lP/kZ6TeqmsKzBJnjTdnTMOAqc7YvhjYyhJDltgpYzU=; b=HtwoRYQxuld8v1KB1qX69uPJTqCwSz3ivCZcEo13FaO+OsiSnciDYSrB m/5KZVeLaaAw79N+bUxVOl/bc1ZkSKTyOu0qUx80HLLiK2czlj4H813zM O9bCZQhG131WmBPEjj/GhSej6ANPpU/S1vRyntK0TQZWwU3Fs66LNRN1w hLqEuEQXThBlWwxPl400AfKeUA2N1GJoRQ/GInqWkOE7taiDem3Ll04f4 g3SZ78vczj9mXKsSVkhjuRibuvOdjhoVDeyPGuU3dpjvxEcoGCMbN29TI o79c27HstSowgZq0HlUi84UBaquB9uZxoV9NlRxydXsQYq0pKX/HEKCfe g==; X-CSE-ConnectionGUID: lh6LSGPSQFaaqnuCLU/11g== X-CSE-MsgGUID: flQY8OSbSYSubk91Zataag== X-IronPort-AV: E=McAfee;i="6800,10657,11847"; a="88706368" X-IronPort-AV: E=Sophos;i="6.25,166,1779174000"; d="scan'208";a="88706368" Received: from fmviesa008.fm.intel.com ([10.60.135.148]) by orvoesa106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Jul 2026 13:34:00 -0700 X-CSE-ConnectionGUID: 86iZV1M1TbaqZx4os16d8A== X-CSE-MsgGUID: QHDqJtX8RnG0dzGvQdQS/Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.25,166,1779174000"; d="scan'208";a="253680976" Received: from mcapezzu-mobl1.amr.corp.intel.com (HELO adixit-MOBL3.intel.com) ([10.125.38.25]) by fmviesa008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Jul 2026 13:33:59 -0700 Date: Wed, 15 Jul 2026 13:33:58 -0700 Message-ID: <87pl0ogfgp.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Kamil Konieczny , "Dixit, Ashutosh" , Shekhar Chauhan , igt-dev@lists.freedesktop.org Subject: Re: [PATCH v2] tools/xe-perf-recorder: Add mmio-trigger support In-Reply-To: <20260714112304.rtb5vtsuamsz62sp@kamilkon-DESK.igk.intel.com> References: <20260702052315.3740840-1-shekhar.chauhan@intel.com> <87pl0uctb4.wl-ashutosh.dixit@intel.com> <87o6gect48.wl-ashutosh.dixit@intel.com> <20260714112304.rtb5vtsuamsz62sp@kamilkon-DESK.igk.intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: igt-dev@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development mailing list for IGT GPU Tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" On Tue, 14 Jul 2026 04:23:04 -0700, Kamil Konieczny wrote: > Hi Kamil, > > On second thoughts, let us leave check_mmio_trigger_report() in (as is) for > > now, so we will at least have some indication and my guess is we will > > occasionally see the second mmio triggered report missing. > > > > So let us leave it in for now and later fix it by a future patch. > > > > imho function should be renamed. As Jani wrote: "Please don't > add functions named "check something". It's one of the most > ambiguous verbs you could use in a function name." Would you have a reference to this, so we can see what Jani means? Or what would you think is a better name for the function? Thanks. -- Ashutosh