From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2BE0BC43458 for ; Wed, 8 Jul 2026 21:50:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=T1XU8gySyfCyfMPo4D3VijlBljRPDdnORGrkJLsD+ik=; b=qVjU3eTNDnNS4G pnGPM1NH/EpmW4A+HAMmCP51/d9hfzsKPHLmlDtxNpc7nicrfZ6prtVXLtRbxgKHRrJ2h8Q6llT3D 3xuvhL9LAc2S91P43aUa1HRfIB+k9U5P18lMuoktLrV1c2vbtkMerm8/T6cFvd3btWmYLemQMxVKV FiJCKTPEAQtqYl2zvg+iJSJ6h+Uw229q6SozXdvZsCm/FIkv4MfmK0JRCwX3rlHy0TAORdO6nMGim NiG+LiXrgmiGlshhY9G6LhyAHTPVpavhw55/D32Q/vSqW2Kxa/1nUOtTRcP6Mvh5JvOOyYt4rnpk4 6pNitvOJBQwpx5qunAaA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wha9b-00000000T5i-0cSx; Wed, 08 Jul 2026 21:50:03 +0000 Received: from sea.source.kernel.org ([172.234.252.31]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wha9Z-00000000T5E-1EW5; Wed, 08 Jul 2026 21:50:01 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id B674B42B57; Wed, 8 Jul 2026 21:50:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C6ADD1F000E9; Wed, 8 Jul 2026 21:49:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783547400; bh=vmuHxwYgqm1gQOMh7c/wvEC96VXO05kzD/lM2vW9atQ=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=LQXgoHnJBN1jyue5u35c/dE+tvbdFa3zUViq7zqGblJh/ZruG6J0COcocKehdLFfd 4xXw/bCoVIbrdpJZ1yxvDgT9U95yzkk950wT9I897knLqsLOwWpBR6zC0Wl0OmKtGN qA7xvyVuCxc36Uggfu07lBhQDGgG4EE5F0SW1Nvv4sJgy854Xef255mh0e3TvqBF2r SBr4Ish5mjPGiV3ozZVjDpPopq53Klt37AdVF1ulSRh47ns0ya3XPMuPgRNdRIF3jm 1AeWmFDRhRZWLT6auHwI3KvNlkgzOBPY9SYSho4DzEN/jTu7kl2ls2cvpTtmqLBfh9 CtbtIsoeAAukg== From: Thomas Gleixner To: Oleg Nesterov Cc: Jinjie Ruan , LKML , Peter Zijlstra , Mark Rutland , Kees Cook , Andy Lutomirski , Richard Henderson , Russell King , Catalin Marinas , Guo Ren , Geert Uytterhoeven , Thomas Bogendoerfer , Helge Deller , Yoshinori Sato , Richard Weinberger , Chris Zankel , linux-arm-kernel@lists.infradead.org, linux-alpha@vger.kernel.org, linux-csky@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-sh@vger.kernel.org, linux-um@lists.infradead.org, Michael Ellerman , Shrikanth Hegde , linuxppc-dev@lists.ozlabs.org, Huacai Chen , loongarch@lists.linux.dev, Paul Walmsley , Palmer Dabbelt , linux-riscv@lists.infradead.org, Sven Schnelle , linux-s390@vger.kernel.org, x86@kernel.org, Arnd Bergmann , Vineet Gupta , Will Deacon , Brian Cain , Michal Simek , Dinh Nguyen , "David S. Miller" , Andreas Larsson , linux-snps-arc@lists.infradead.org, linux-hexagon@vger.kernel.org, linux-openrisc@vger.kernel.org, sparclinux@vger.kernel.org, linux-arch@vger.kernel.org, Michal =?utf-8?Q?Such=C3=A1nek?= , Jonathan Corbet , linux-doc@vger.kernel.org Subject: Re: [patch 11/18] seccomp, treewide: Rename and convert __secure_computing() to return boolean In-Reply-To: References: <20260707181957.433213175@kernel.org> <20260707190254.230735780@kernel.org> <2e6ed364-ce8f-4b4b-8675-acd07f140f4f@huawei.com> <871pddsuzl.ffs@fw13> Date: Wed, 08 Jul 2026 23:49:57 +0200 Message-ID: <87pl0xqhh6.ffs@fw13> MIME-Version: 1.0 X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Wed, Jul 08 2026 at 18:04, Oleg Nesterov wrote: > On 07/08, Thomas Gleixner wrote: >> >> On Wed, Jul 08 2026 at 09:43, Jinjie Ruan wrote: >> > >> > The return value of __seccomp_filter is checked in the wrong way, check >> > -1 should be replaced with check false, maybe: >> > >> > - if (__seccomp_filter(this_syscall, true)) >> > - return -1; >> > + if (!__seccomp_filter(this_syscall, true)) >> > + return false; > > Or simply > > return __seccomp_filter(this_syscall, true); > > and remove "return true" below ? Duh. Obvious now that you point it out :) > Either way, I personally like this change, I was always confused by these -1's. Welcome to the club! _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 51B59C43458 for ; Wed, 8 Jul 2026 21:50:06 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4gwWwX3Znpz2yd7; Thu, 09 Jul 2026 07:50:04 +1000 (AEST) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip=172.234.252.31 ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1783547404; cv=none; b=mJliSwPoi1oQ6h6t+D+rolDXe9j3lHDTH8+hBM4RRp7mWGYaGItLssSZbkahiFoomB/XSNKg+yvdZCQ68fDmxdTOd6mR5vmScYsc3NhobieRuEgB+9HfQVhBICJnYFXncpmLaWebNOowHLX1WPQQF1lNtzEC7JbK9sq7ldq1MRf53Vy9ft61QO4J7WBEirZkCC0ea4iVSyrKd8uc/tPpECL0yAl8ady18YDxKwISinWBpd5CXm0NGbkLBuaIRrZoxx9EaJect1nGpP49s1sQ+yGaZEbOYh8G7SBlhZZ+shUKzppoygnjjyRtgvEjzSrZufSpSJP8/Tt1KdQttZ5LFQ== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1783547404; c=relaxed/relaxed; bh=vmuHxwYgqm1gQOMh7c/wvEC96VXO05kzD/lM2vW9atQ=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=aM0GuoyFc/K95wz3j8cFZs9Z1bgijZ16nZjccE3v4IvdTjfuFLD5Klnc/0F80cnzE5PnyIeplo8LinCl3ySBNDsLjJGlzapW5kaFqDRqHjYjNAAUiWqX6ge7ywGL+YpDHe7luvYH1FOFbgM1LPWs9bgyxztRTIkol8K3xfHR0dFbvipC9IxDtY7G9oglpnjFM4DgA66S02AwGABkSFE3DtCnOI6/H/13wT14miTB39J4addyH5GUq+dJYMwA7mGnVcjfo6aVBKsE9Rr4ilqCxrLvXsvJEDze+CmjP2GxkcfVCtGn+sDhtSE1psvchGashoki4PH4n6Bh5uUa7RdZag== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=LQXgoHnJ; dkim-atps=neutral; spf=pass (client-ip=172.234.252.31; helo=sea.source.kernel.org; envelope-from=tglx@kernel.org; receiver=lists.ozlabs.org) smtp.mailfrom=kernel.org Authentication-Results: lists.ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=LQXgoHnJ; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=172.234.252.31; helo=sea.source.kernel.org; envelope-from=tglx@kernel.org; receiver=lists.ozlabs.org) Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4gwWwW2j7qz2y7r for ; Thu, 09 Jul 2026 07:50:03 +1000 (AEST) Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id B674B42B57; Wed, 8 Jul 2026 21:50:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C6ADD1F000E9; Wed, 8 Jul 2026 21:49:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783547400; bh=vmuHxwYgqm1gQOMh7c/wvEC96VXO05kzD/lM2vW9atQ=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=LQXgoHnJBN1jyue5u35c/dE+tvbdFa3zUViq7zqGblJh/ZruG6J0COcocKehdLFfd 4xXw/bCoVIbrdpJZ1yxvDgT9U95yzkk950wT9I897knLqsLOwWpBR6zC0Wl0OmKtGN qA7xvyVuCxc36Uggfu07lBhQDGgG4EE5F0SW1Nvv4sJgy854Xef255mh0e3TvqBF2r SBr4Ish5mjPGiV3ozZVjDpPopq53Klt37AdVF1ulSRh47ns0ya3XPMuPgRNdRIF3jm 1AeWmFDRhRZWLT6auHwI3KvNlkgzOBPY9SYSho4DzEN/jTu7kl2ls2cvpTtmqLBfh9 CtbtIsoeAAukg== From: Thomas Gleixner To: Oleg Nesterov Cc: Jinjie Ruan , LKML , Peter Zijlstra , Mark Rutland , Kees Cook , Andy Lutomirski , Richard Henderson , Russell King , Catalin Marinas , Guo Ren , Geert Uytterhoeven , Thomas Bogendoerfer , Helge Deller , Yoshinori Sato , Richard Weinberger , Chris Zankel , linux-arm-kernel@lists.infradead.org, linux-alpha@vger.kernel.org, linux-csky@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-sh@vger.kernel.org, linux-um@lists.infradead.org, Michael Ellerman , Shrikanth Hegde , linuxppc-dev@lists.ozlabs.org, Huacai Chen , loongarch@lists.linux.dev, Paul Walmsley , Palmer Dabbelt , linux-riscv@lists.infradead.org, Sven Schnelle , linux-s390@vger.kernel.org, x86@kernel.org, Arnd Bergmann , Vineet Gupta , Will Deacon , Brian Cain , Michal Simek , Dinh Nguyen , "David S. Miller" , Andreas Larsson , linux-snps-arc@lists.infradead.org, linux-hexagon@vger.kernel.org, linux-openrisc@vger.kernel.org, sparclinux@vger.kernel.org, linux-arch@vger.kernel.org, Michal =?utf-8?Q?Such=C3=A1nek?= , Jonathan Corbet , linux-doc@vger.kernel.org Subject: Re: [patch 11/18] seccomp, treewide: Rename and convert __secure_computing() to return boolean In-Reply-To: References: <20260707181957.433213175@kernel.org> <20260707190254.230735780@kernel.org> <2e6ed364-ce8f-4b4b-8675-acd07f140f4f@huawei.com> <871pddsuzl.ffs@fw13> Date: Wed, 08 Jul 2026 23:49:57 +0200 Message-ID: <87pl0xqhh6.ffs@fw13> X-Mailing-List: linuxppc-dev@lists.ozlabs.org List-Id: List-Help: List-Owner: List-Post: List-Archive: , List-Subscribe: , , List-Unsubscribe: Precedence: list MIME-Version: 1.0 Content-Type: text/plain On Wed, Jul 08 2026 at 18:04, Oleg Nesterov wrote: > On 07/08, Thomas Gleixner wrote: >> >> On Wed, Jul 08 2026 at 09:43, Jinjie Ruan wrote: >> > >> > The return value of __seccomp_filter is checked in the wrong way, check >> > -1 should be replaced with check false, maybe: >> > >> > - if (__seccomp_filter(this_syscall, true)) >> > - return -1; >> > + if (!__seccomp_filter(this_syscall, true)) >> > + return false; > > Or simply > > return __seccomp_filter(this_syscall, true); > > and remove "return true" below ? Duh. Obvious now that you point it out :) > Either way, I personally like this change, I was always confused by these -1's. Welcome to the club! From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7DEB8C43458 for ; Wed, 8 Jul 2026 21:50:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Lux9i502yb9psaHRgyZ+yWjrxGDaAH6on8xZQsHiUgI=; b=lt5m+T6uYiMbep ItieAnrNDX2F2bg6ADVohuxtln52gLQDbBMXRbsbxuqrEww4D69CAZj2Rab4vXtac0d9lA7xiR0+C hSz3qfLBpcZ7/3qwwzpF4Uw9n4D9LLQ/trkESXZjzXs1mwM9twaUYYr3KrfqSnkPnLfQVgXB3dHnp XA2pFvfsdeNjuRaYG8RaYGJE6eVKanbtBD6HQTSIbHRGLQ/fw4wY11oJ2UpIEQsZgSE9/QTLfs6Pd gVcq6I8CCrvPrbMf9YyXG966AYm2Q2nzX3JhFfraaawTtkzdkJGqWuK3ufRviIo9SCspj6ylcmGrR UZeIlCWcpd6Pp+h/249Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wha9b-00000000T5m-0w2B; Wed, 08 Jul 2026 21:50:03 +0000 Received: from sea.source.kernel.org ([172.234.252.31]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wha9Z-00000000T5E-1EW5; Wed, 08 Jul 2026 21:50:01 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id B674B42B57; Wed, 8 Jul 2026 21:50:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C6ADD1F000E9; Wed, 8 Jul 2026 21:49:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783547400; bh=vmuHxwYgqm1gQOMh7c/wvEC96VXO05kzD/lM2vW9atQ=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=LQXgoHnJBN1jyue5u35c/dE+tvbdFa3zUViq7zqGblJh/ZruG6J0COcocKehdLFfd 4xXw/bCoVIbrdpJZ1yxvDgT9U95yzkk950wT9I897knLqsLOwWpBR6zC0Wl0OmKtGN qA7xvyVuCxc36Uggfu07lBhQDGgG4EE5F0SW1Nvv4sJgy854Xef255mh0e3TvqBF2r SBr4Ish5mjPGiV3ozZVjDpPopq53Klt37AdVF1ulSRh47ns0ya3XPMuPgRNdRIF3jm 1AeWmFDRhRZWLT6auHwI3KvNlkgzOBPY9SYSho4DzEN/jTu7kl2ls2cvpTtmqLBfh9 CtbtIsoeAAukg== From: Thomas Gleixner To: Oleg Nesterov Cc: Jinjie Ruan , LKML , Peter Zijlstra , Mark Rutland , Kees Cook , Andy Lutomirski , Richard Henderson , Russell King , Catalin Marinas , Guo Ren , Geert Uytterhoeven , Thomas Bogendoerfer , Helge Deller , Yoshinori Sato , Richard Weinberger , Chris Zankel , linux-arm-kernel@lists.infradead.org, linux-alpha@vger.kernel.org, linux-csky@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-sh@vger.kernel.org, linux-um@lists.infradead.org, Michael Ellerman , Shrikanth Hegde , linuxppc-dev@lists.ozlabs.org, Huacai Chen , loongarch@lists.linux.dev, Paul Walmsley , Palmer Dabbelt , linux-riscv@lists.infradead.org, Sven Schnelle , linux-s390@vger.kernel.org, x86@kernel.org, Arnd Bergmann , Vineet Gupta , Will Deacon , Brian Cain , Michal Simek , Dinh Nguyen , "David S. Miller" , Andreas Larsson , linux-snps-arc@lists.infradead.org, linux-hexagon@vger.kernel.org, linux-openrisc@vger.kernel.org, sparclinux@vger.kernel.org, linux-arch@vger.kernel.org, Michal =?utf-8?Q?Such=C3=A1nek?= , Jonathan Corbet , linux-doc@vger.kernel.org Subject: Re: [patch 11/18] seccomp, treewide: Rename and convert __secure_computing() to return boolean In-Reply-To: References: <20260707181957.433213175@kernel.org> <20260707190254.230735780@kernel.org> <2e6ed364-ce8f-4b4b-8675-acd07f140f4f@huawei.com> <871pddsuzl.ffs@fw13> Date: Wed, 08 Jul 2026 23:49:57 +0200 Message-ID: <87pl0xqhh6.ffs@fw13> MIME-Version: 1.0 X-BeenThere: linux-snps-arc@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux on Synopsys ARC Processors List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-snps-arc" Errors-To: linux-snps-arc-bounces+linux-snps-arc=archiver.kernel.org@lists.infradead.org On Wed, Jul 08 2026 at 18:04, Oleg Nesterov wrote: > On 07/08, Thomas Gleixner wrote: >> >> On Wed, Jul 08 2026 at 09:43, Jinjie Ruan wrote: >> > >> > The return value of __seccomp_filter is checked in the wrong way, check >> > -1 should be replaced with check false, maybe: >> > >> > - if (__seccomp_filter(this_syscall, true)) >> > - return -1; >> > + if (!__seccomp_filter(this_syscall, true)) >> > + return false; > > Or simply > > return __seccomp_filter(this_syscall, true); > > and remove "return true" below ? Duh. Obvious now that you point it out :) > Either way, I personally like this change, I was always confused by these -1's. Welcome to the club! _______________________________________________ linux-snps-arc mailing list linux-snps-arc@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-snps-arc