All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Ai Chao <aichao@kylinos.cn>
Cc: perex@perex.cz, tiwai@suse.com, kees@kernel.org,
	linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: pcm: Show closed for DISCONNECTED state
Date: Fri, 19 Jun 2026 15:34:22 +0200	[thread overview]
Message-ID: <87pl1mirhd.wl-tiwai@suse.de> (raw)
In-Reply-To: <20260619092936.806715-1-aichao@kylinos.cn>

On Fri, 19 Jun 2026 11:29:36 +0200,
Ai Chao wrote:
> 
> Hello Takashi
> 
> > Right, I suspect that it might be the case.
> > Does the change like below help (or worsen) anything?
> 
> We tested this solution and verified its feasibility.

OK, then I'm going to submit a proper patch later.

As it's a bit drastic change and it's already in a merge window for
7.2, I'd postpone the fix for 7.3.


thanks,

Takashi

> 
> Thanks,
> Ai Chao
> 
> --- a/sound/core/pcm_native.c
> +++ b/sound/core/pcm_native.c
> @@ -3907,6 +3907,8 @@ static vm_fault_t snd_pcm_mmap_data_fault(struct vm_fault *vmf)
>      if (substream == NULL)
>          return VM_FAULT_SIGBUS;
>      runtime = substream->runtime;
> +    if (runtime->state == SNDRV_PCM_STATE_DISCONNECTED)
> +        return VM_FAULT_SIGBUS;
>      offset = vmf->pgoff << PAGE_SHIFT;
>      dma_bytes = PAGE_ALIGN(runtime->dma_bytes);
>      if (offset > dma_bytes - PAGE_SIZE)
> 

  reply	other threads:[~2026-06-19 13:34 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-19  9:29 Re: Re: [PATCH] ALSA: pcm: Show closed for DISCONNECTED state Ai Chao
2026-06-19 13:34 ` Takashi Iwai [this message]
  -- strict thread matches above, loose matches on Subject: below --
2026-06-17  7:19 Ai Chao
2026-06-17  8:36 ` Jaroslav Kysela
2026-06-17  8:53   ` Takashi Iwai
2026-06-16  2:06 Ai Chao
2026-06-16  7:24 ` Takashi Iwai
2026-06-15 13:26 Ai Chao
2026-06-15 13:51 ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pl1mirhd.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=aichao@kylinos.cn \
    --cc=kees@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.