All of lore.kernel.org
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: Pierrick Bouvier <pierrick.bouvier@oss.qualcomm.com>
Cc: "Philippe Mathieu-Daudé" <philmd@linaro.org>,
	qemu-devel@nongnu.org, "Brian Cain" <brian.cain@oss.qualcomm.com>
Subject: Re: [PATCH] MAINTAINERS: Fix hexagon-linux-user.mak path
Date: Wed, 20 May 2026 20:10:29 +0200	[thread overview]
Message-ID: <87pl2qgdey.fsf@pond.sub.org> (raw)
In-Reply-To: <114b06cc-c6a0-4d09-89ae-f23b45965f19@oss.qualcomm.com> (Pierrick Bouvier's message of "Wed, 20 May 2026 12:28:44 -0500")

Pierrick Bouvier <pierrick.bouvier@oss.qualcomm.com> writes:

> On 5/20/2026 7:52 AM, Markus Armbruster wrote:
>> Philippe Mathieu-Daudé <philmd@linaro.org> writes:
>> 
>>> Fixes: 812b31d3f91 ("configs: rename default-configs to configs and reorganise")
>>> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
>>> ---
>>>  MAINTAINERS | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/MAINTAINERS b/MAINTAINERS
>>> index b75f3222f2f..2a4d124fb3c 100644
>>> --- a/MAINTAINERS
>>> +++ b/MAINTAINERS
>>> @@ -256,7 +256,7 @@ X: target/hexagon/gen_idef_parser_funcs.py
>>>  F: linux-user/hexagon/
>>>  F: tests/tcg/hexagon/
>>>  F: disas/hexagon.c
>>> -F: configs/targets/hexagon-linux-user/default.mak
>>> +F: configs/targets/hexagon-linux-user.mak
>>>  F: docker/dockerfiles/debian-hexagon-cross.docker
>> 
>> This one's wrong, too.
>> 
>> I have an unsent patch fixing both.  In fact, I have an unsent series
>> fixing *all* F: patterns that don't resolve to any file.
>>
>
> I planned to take a look at this, and would be happy to review yours.

I hope to post tomorrow.  Review is always appreciated!

> Any chance you have a script that we could integrate directly into our
> meson.build? (I feel it's better than checkpatch, since checkpatch is
> not blocking anything CI wise).

Good idea.

Here's my quick & dirty way to find broke F:

    $ ls `sed -n 's/^F: *//p' MAINTAINERS ` >/dev/null

Easily fooled by untracked files.  I double-checked in a fresh clone
just to be sure.

> This way, any time a project is configured (not built, configured), it
> would trigger a check. Since every file removal/adding implies a
> meson.build modification, it should keep the MAINTAINERS file consistent
> by design.

Yep.

>>>  F: gdbstub/gdb-xml/hexagon*.xml
>>>  T: git https://github.com/quic/qemu.git hex-next



  reply	other threads:[~2026-05-20 18:11 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-20 12:39 [PATCH] MAINTAINERS: Fix hexagon-linux-user.mak path Philippe Mathieu-Daudé
2026-05-20 12:52 ` Markus Armbruster
2026-05-20 12:57   ` Philippe Mathieu-Daudé
2026-05-20 12:59     ` Philippe Mathieu-Daudé
2026-05-20 13:09       ` Markus Armbruster
2026-05-20 13:44         ` Markus Armbruster
2026-05-20 14:05         ` Philippe Mathieu-Daudé
2026-05-20 14:43           ` Markus Armbruster
2026-05-20 15:13           ` Pierrick Bouvier
2026-05-20 17:28   ` Pierrick Bouvier
2026-05-20 18:10     ` Markus Armbruster [this message]
2026-05-20 13:38 ` Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pl2qgdey.fsf@pond.sub.org \
    --to=armbru@redhat.com \
    --cc=brian.cain@oss.qualcomm.com \
    --cc=philmd@linaro.org \
    --cc=pierrick.bouvier@oss.qualcomm.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.