From: Takashi Iwai <tiwai@suse.de>
To: Jiakai Xu <xujiakai24@mails.ucas.ac.cn>
Cc: tiwai@suse.de, kees@kernel.org, linux-kernel@vger.kernel.org,
linux-sound@vger.kernel.org, o-takashi@sakamocchi.jp,
perex@perex.cz, tiwai@suse.com, zzzccc427@gmail.com
Subject: Re: [PATCH] ALSA: pcm: oss: Use snd_pcm_kernel_write() in snd_pcm_oss_sync()
Date: Sun, 17 May 2026 18:09:13 +0200 [thread overview]
Message-ID: <87pl2udnme.wl-tiwai@suse.de> (raw)
In-Reply-To: <20260517133608.540165-1-xujiakai24@mails.ucas.ac.cn>
On Sun, 17 May 2026 15:36:08 +0200,
Jiakai Xu wrote:
>
> Thank you for your review, Takashi.
>
> > Thanks for the patch. I believe the problem is rather in
> > do_transfer() setting up a bogus iter for silencing unnecessarily.
> > So it's a bug introduced in the commit cf393babb37a ("ALSA: pcm: Add
> > copy ops with iov_iter").
>
> I agree with your analysis. The root cause is indeed in
> interleaved_copy() ― it should not pass a NULL data pointer to
> do_transfer(), which then unnecessarily constructs an iov_iter.
>
> > Could you verify whether the change below works instead?
> > noninterleaved_copy() has already the handling of NULL data.
>
> Unfortunately, this crash was discovered through fuzzing, and
> the fuzzer did not generate a reproducer. As a result, I am unable to
> test the fix directly. However, the fix looks correct to me.
OK, no problem. Then I'm going to submit a proper patch later.
Thanks for your checking!
Takashi
prev parent reply other threads:[~2026-05-17 16:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-15 5:15 [PATCH] ALSA: pcm: oss: Use snd_pcm_kernel_write() in snd_pcm_oss_sync() Jiakai Xu
2026-05-15 8:01 ` Takashi Iwai
2026-05-17 13:36 ` Jiakai Xu
2026-05-17 16:09 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pl2udnme.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=kees@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=o-takashi@sakamocchi.jp \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
--cc=xujiakai24@mails.ucas.ac.cn \
--cc=zzzccc427@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.