From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 96637EFCE5F for ; Thu, 5 Mar 2026 03:42:02 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 388DE10E160; Thu, 5 Mar 2026 03:42:02 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="DXB+Y6Y3"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id 605D210E160 for ; Thu, 5 Mar 2026 03:42:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1772682121; x=1804218121; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=mz9c+HyZcCeQWYuoJ5Bwl7clr+gk7K7+Y32lcIFSOt0=; b=DXB+Y6Y3rAuNuVFROBeq+lf6YBK7picHqm7+ghYkkHyK7J2p6XKwXzZ7 NX3uep2U/RhqeSqJjnUykjwNL6FlOoAfK1NYoxdPCJ3AUBWxP7epV2Ul3 5jjQQUHQFE/3j7CWvestA7df0KAjIxP7lOhsUYJw7mT+8enHJzsSdK+I4 r7My4dIUUC7AY4wuZZryw9kbd6TmKeETAK2L3SkJLplcaGISLxcYDGWUk qRqDaYN94ndxKu0/b6vgAvymh71XvOwScL8glglaM0jMfLei0Klw09kW9 jYQ3Y4WIRu/2qAnSIyzoBmfM1KEOiwxTndfenFtLuFDyiTDRSGouASqGm A==; X-CSE-ConnectionGUID: L2qG3mwFQS+K+8B/4vvRLA== X-CSE-MsgGUID: mJ+9N98yTt2KYw/dX+qsvQ== X-IronPort-AV: E=McAfee;i="6800,10657,11719"; a="77360806" X-IronPort-AV: E=Sophos;i="6.21,325,1763452800"; d="scan'208";a="77360806" Received: from fmviesa003.fm.intel.com ([10.60.135.143]) by orvoesa107.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Mar 2026 19:41:58 -0800 X-CSE-ConnectionGUID: H+TOVSOQT6CNblM/DLqoiQ== X-CSE-MsgGUID: B6AhQDGbQyauYdq3/iwlbA== X-ExtLoop1: 1 Received: from rmigue1x-mobl.amr.corp.intel.com (HELO adixit-MOBL3.intel.com) ([10.125.38.160]) by fmviesa003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Mar 2026 19:41:57 -0800 Date: Wed, 04 Mar 2026 19:41:56 -0800 Message-ID: <87pl5j54e3.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: "Sharma, Nishit" Cc: "igt-dev@lists.freedesktop.org" , "Girotra, Himanshu" , "Roper, Matthew D" Subject: Re: [PATCH i-g-t] Revert "lib/intel_pat: use kernel debugfs as authoritative PAT source for Xe" In-Reply-To: References: <20260305003047.2290389-1-ashutosh.dixit@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: igt-dev@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development mailing list for IGT GPU Tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" On Wed, 04 Mar 2026 18:27:43 -0800, Sharma, Nishit wrote: > > Hi Ashutosh, > > I understand the concern but the xe_pat patch was reviewed and +1 given > by MattR and with reasoning regarding xe_oa > https://patchwork.freedesktop.org/patch/706754/?series=161927&rev=2 > Hence, we went ahead with the merge. In case if you feel it's major > regression a partial revert of lib changes can be done. Sorry, if you solve fix one area of the code, you can't break a different area. That is the basic premise of software development. The patch should not have been merged when you saw that you were causing regressions and your solution was incomplete.