Re: [PATCH v3 3/3] chardev: add logtimestamp option

[Markus Armbruster <armbru@redhat.com>]

Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru> writes:

> Add an option to inject timestamps into serial log file.
> That simplifies debugging a lot, when you can simply compare
> QEMU logs with guest console logs.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>

[...]

> diff --git a/qapi/char.json b/qapi/char.json
> index 140614f82c..a4abafa680 100644
> --- a/qapi/char.json
> +++ b/qapi/char.json
> @@ -197,11 +197,15 @@
>  # @logappend: true to append instead of truncate (default to false to
>  #     truncate)
>  #
> +# @logtimestamp: true to insert timestamps into logfile
> +#     (default false) (since 11.0)
> +#
>  # Since: 2.6
>  ##
>  { 'struct': 'ChardevCommon',
>    'data': { '*logfile': 'str',
> -            '*logappend': 'bool' } }
> +            '*logappend': 'bool',
> +            '*logtimestamp': 'bool' } }

We prefer to separate words with hyphens in member names (see
docs/devel/qapi-code-gen.rst), but local consistency trumps that rule.

>  
>  ##
>  # @ChardevFile:

QAPI schema
Acked-by: Markus Armbruster <armbru@redhat.com>