Re: [PATCH v4 03/11] plugins: use complete filename for defining plugins sources

["Alex Bennée" <alex.bennee@linaro.org>]

Philippe Mathieu-Daudé <philmd@linaro.org> writes:

> On 28/1/26 12:11, Alex Bennée wrote:
>> Pierrick Bouvier <pierrick.bouvier@linaro.org> writes:
>> 
>>> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
>>> Reviewed-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
>>> Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
>>> ---
>>>   contrib/plugins/meson.build   | 10 +++++-----
>>>   tests/tcg/plugins/meson.build |  7 +++++--
>>>   2 files changed, 10 insertions(+), 7 deletions(-)
>>>
>>> diff --git a/contrib/plugins/meson.build b/contrib/plugins/meson.build
>>> index 6915ffa5fbc..3d2d7862e0c 100644
>>> --- a/contrib/plugins/meson.build
>>> +++ b/contrib/plugins/meson.build
>>> @@ -1,15 +1,15 @@
>>> -contrib_plugins = ['bbv', 'cache', 'cflow', 'drcov', 'execlog', 'hotblocks',
>>> -                   'hotpages', 'howvec', 'hwprofile', 'ips', 'stoptrigger',
>>> -                   'traps', 'uftrace']
>>> +contrib_plugins = ['bbv.c', 'cache.c', 'cflow.c', 'drcov.c', 'execlog.c',
>>> +                   'hotblocks.c', 'hotpages.c', 'howvec.c', 'hwprofile.c',
>>> +                   'ips.c', 'stoptrigger.c', 'traps.c', 'uftrace.c']
>> Argh this keeps conflicting with other changes. Maybe we should make
>> this a dumb list:
>>    contrib_plugins = [ ]
>>    contrib_plugins += 'bbv.c'
>>    contrib_plugins += 'cache.c'
>> etc?
>
> This applies fine as of commit 9ad7f544c69, on what are you based?

plugins/next ;-)

Pierrick is going to deal with the pain now in his first PR!

-- 
Alex Bennée
Virtualisation Tech Lead @ Linaro