Re: [PATCH 5/9] ALSA: opl4: Convert to snd_seq bus probe mechanism

[Takashi Iwai <tiwai@suse.de>]

On Wed, 03 Dec 2025 14:46:27 +0100,
Uwe Kleine-König wrote:
> 
> hello,
> 
> On Tue, Dec 02, 2025 at 01:35:54PM +0100, Uwe Kleine-König wrote:
> > The snd_seq bus got a dedicated probe function. Make use of that. This
> > fixes a runtime warning about the driver needing to be converted to the
> > bus probe method.
> > 
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
> > ---
> >  sound/drivers/opl4/opl4_seq.c | 10 ++++------
> >  1 file changed, 4 insertions(+), 6 deletions(-)
> > 
> > diff --git a/sound/drivers/opl4/opl4_seq.c b/sound/drivers/opl4/opl4_seq.c
> > index 7bb22089a093..043c537be293 100644
> > --- a/sound/drivers/opl4/opl4_seq.c
> > +++ b/sound/drivers/opl4/opl4_seq.c
> > @@ -118,9 +118,8 @@ static void snd_opl4_seq_free_port(void *private_data)
> >  	snd_midi_channel_free_set(opl4->chset);
> >  }
> >  
> > -static int snd_opl4_seq_probe(struct device *_dev)
> > +static int snd_opl4_seq_probe(struct snd_seq_device *dev)
> >  {
> > -	struct snd_seq_device *dev = to_seq_dev(_dev);
> >  	struct snd_opl4 *opl4;
> >  	int client;
> >  	struct snd_seq_port_callback pcallbacks;
> > @@ -175,9 +174,8 @@ static int snd_opl4_seq_probe(struct device *_dev)
> >  	return 0;
> >  }
> >  
> > -static int snd_opl4_seq_remove(struct device *_dev)
> > +static int snd_opl4_seq_remove(struct snd_seq_device *dev)
> >  {
> > -	struct snd_seq_device *dev = to_seq_dev(_dev);
> >  	struct snd_opl4 *opl4;
> >  
> >  	opl4 = *(struct snd_opl4 **)SNDRV_SEQ_DEVICE_ARGPTR(dev);
> 
> There is a build problem that escaped my build testing (on arm64). This
> additionally needs:
> 
> diff --git a/sound/drivers/opl4/opl4_seq.c b/sound/drivers/opl4/opl4_seq.c
> index 043c537be293..fd6f15be6109 100644
> --- a/sound/drivers/opl4/opl4_seq.c
> +++ b/sound/drivers/opl4/opl4_seq.c
> @@ -174,19 +174,18 @@ static int snd_opl4_seq_probe(struct snd_seq_device *dev)
>  	return 0;
>  }
>  
> -static int snd_opl4_seq_remove(struct snd_seq_device *dev)
> +static void snd_opl4_seq_remove(struct snd_seq_device *dev)
>  {
>  	struct snd_opl4 *opl4;
>  
>  	opl4 = *(struct snd_opl4 **)SNDRV_SEQ_DEVICE_ARGPTR(dev);
>  	if (!opl4)
> -		return -EINVAL;
> +		return;
>  
>  	if (opl4->seq_client >= 0) {
>  		snd_seq_delete_kernel_client(opl4->seq_client);
>  		opl4->seq_client = -1;
>  	}
> -	return 0;
>  }
>  
>  static struct snd_seq_driver opl4_seq_driver = {
> 
> I don't know if it's already applied, please tell me if you want a v2 or
> a proper patch on top of this (or if you even squash this into the
> original commit).
> 
> Sorry for the mess

Don't worry, I haven't applied them yet, so feel free to resubmit.


thanks,

Takashi