All of lore.kernel.org
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: "Rob Herring (Arm)" <robh@kernel.org>
Cc: Richard Weinberger <richard@nod.at>,
	 Vignesh Raghavendra <vigneshr@ti.com>,
	 Nicolas Ferre <nicolas.ferre@microchip.com>,
	Alexandre Belloni <alexandre.belloni@bootlin.com>,
	 Claudiu Beznea <claudiu.beznea@tuxon.dev>,
	 Russell King <linux@armlinux.org.uk>,
	linux-mtd@lists.infradead.org,
	 linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/3] mtd: nand: atmel: Defer probe if SRAM is missing
Date: Fri, 21 Nov 2025 15:15:51 +0100	[thread overview]
Message-ID: <87pl9bzd2g.fsf@bootlin.com> (raw)
In-Reply-To: <20251120-at91-probe-v2-1-8c8592f02e8e@kernel.org> (Rob Herring's message of "Thu, 20 Nov 2025 15:37:50 -0600")

Hello Rob,

> diff --git a/drivers/mtd/nand/raw/atmel/nand-controller.c b/drivers/mtd/nand/raw/atmel/nand-controller.c
> index 83ba4ebd02d4..e60998eb754b 100644
> --- a/drivers/mtd/nand/raw/atmel/nand-controller.c
> +++ b/drivers/mtd/nand/raw/atmel/nand-controller.c
> @@ -2306,7 +2306,7 @@ atmel_hsmc_nand_controller_init(struct atmel_hsmc_nand_controller *nc)
>  					 "atmel,nfc-sram", 0);
>  	if (!nc->sram.pool) {
>  		dev_err(nc->base.dev, "Missing SRAM\n");
> -		return -ENOMEM;
> +		return -EPROBE_DEFER;

I am totally fine with the idea of probe deferral, however I think the
policy is to avoid making noise when this happens. The dev_err() call is
no longer relevant there. You can either lower it to dev_dbg() manually
or, at your convenience, return with:

   return dev_err_probe(nc->base.dev, "Missing SRAM\n", -EPROBE_DEFER);

Thanks,
Miquèl


WARNING: multiple messages have this Message-ID (diff)
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: "Rob Herring (Arm)" <robh@kernel.org>
Cc: Richard Weinberger <richard@nod.at>,
	 Vignesh Raghavendra <vigneshr@ti.com>,
	 Nicolas Ferre <nicolas.ferre@microchip.com>,
	Alexandre Belloni <alexandre.belloni@bootlin.com>,
	 Claudiu Beznea <claudiu.beznea@tuxon.dev>,
	 Russell King <linux@armlinux.org.uk>,
	linux-mtd@lists.infradead.org,
	 linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/3] mtd: nand: atmel: Defer probe if SRAM is missing
Date: Fri, 21 Nov 2025 15:15:51 +0100	[thread overview]
Message-ID: <87pl9bzd2g.fsf@bootlin.com> (raw)
In-Reply-To: <20251120-at91-probe-v2-1-8c8592f02e8e@kernel.org> (Rob Herring's message of "Thu, 20 Nov 2025 15:37:50 -0600")

Hello Rob,

> diff --git a/drivers/mtd/nand/raw/atmel/nand-controller.c b/drivers/mtd/nand/raw/atmel/nand-controller.c
> index 83ba4ebd02d4..e60998eb754b 100644
> --- a/drivers/mtd/nand/raw/atmel/nand-controller.c
> +++ b/drivers/mtd/nand/raw/atmel/nand-controller.c
> @@ -2306,7 +2306,7 @@ atmel_hsmc_nand_controller_init(struct atmel_hsmc_nand_controller *nc)
>  					 "atmel,nfc-sram", 0);
>  	if (!nc->sram.pool) {
>  		dev_err(nc->base.dev, "Missing SRAM\n");
> -		return -ENOMEM;
> +		return -EPROBE_DEFER;

I am totally fine with the idea of probe deferral, however I think the
policy is to avoid making noise when this happens. The dev_err() call is
no longer relevant there. You can either lower it to dev_dbg() manually
or, at your convenience, return with:

   return dev_err_probe(nc->base.dev, "Missing SRAM\n", -EPROBE_DEFER);

Thanks,
Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

  reply	other threads:[~2025-11-21 14:16 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-20 21:37 [PATCH v2 0/3] at91: Remove of_platform_default_populate() calls Rob Herring (Arm)
2025-11-20 21:37 ` Rob Herring (Arm)
2025-11-20 21:37 ` [PATCH v2 1/3] mtd: nand: atmel: Defer probe if SRAM is missing Rob Herring (Arm)
2025-11-20 21:37   ` Rob Herring (Arm)
2025-11-21 14:15   ` Miquel Raynal [this message]
2025-11-21 14:15     ` Miquel Raynal
2025-11-20 21:37 ` [PATCH v2 2/3] ARM: at91: Move PM init functions to .init_late hook Rob Herring
2025-11-20 21:37   ` Rob Herring
2025-11-22 15:37   ` Claudiu Beznea
2025-11-22 15:37     ` Claudiu Beznea
2025-12-09 22:39     ` Rob Herring
2025-12-09 22:39       ` Rob Herring
2025-12-10  8:04       ` Claudiu Beznea
2025-12-10  8:04         ` Claudiu Beznea
2025-11-20 21:37 ` [PATCH v2 3/3] ARM: at91: remove unnecessary of_platform_default_populate calls Rob Herring (Arm)
2025-11-20 21:37   ` Rob Herring (Arm)
2025-11-22 15:37   ` Claudiu Beznea
2025-11-22 15:37     ` Claudiu Beznea
2025-12-12 17:37 ` [PATCH v2 0/3] at91: Remove of_platform_default_populate() calls Alexandre Belloni
2025-12-12 17:37   ` Alexandre Belloni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pl9bzd2g.fsf@bootlin.com \
    --to=miquel.raynal@bootlin.com \
    --cc=alexandre.belloni@bootlin.com \
    --cc=claudiu.beznea@tuxon.dev \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=linux@armlinux.org.uk \
    --cc=nicolas.ferre@microchip.com \
    --cc=richard@nod.at \
    --cc=robh@kernel.org \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.