All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: K Prateek Nayak <kprateek.nayak@amd.com>,
	LKML <linux-kernel@vger.kernel.org>
Cc: Arnd Bergmann <arnd@arndb.de>,
	linux-arch@vger.kernel.org, Peter Zilstra <peterz@infradead.org>,
	Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
	"Paul E. McKenney" <paulmck@kernel.org>,
	Boqun Feng <boqun.feng@gmail.com>,
	Jonathan Corbet <corbet@lwn.net>,
	Prakash Sangappa <prakash.sangappa@oracle.com>,
	Madadi Vineeth Reddy <vineethr@linux.ibm.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Subject: Re: [patch 06/12] rseq: Implement sys_rseq_slice_yield()
Date: Tue, 09 Sep 2025 14:23:38 +0200	[thread overview]
Message-ID: <87plbzvmph.ffs@tglx> (raw)
In-Reply-To: <47499513-7bf0-4393-ba89-5efd9c115c43@amd.com>

On Tue, Sep 09 2025 at 15:22, K. Prateek Nayak wrote:
> On 9/9/2025 4:30 AM, Thomas Gleixner wrote:
>>  /* restartable sequence */
>>  COND_SYSCALL(rseq);
>> +COND_SYSCALL(rseq_sched_yield);
>
> I'm not sure if it is my toolchain but when I try to build a version
> with CONFIG_RSEQ_SLICE_EXTENSION disabled, I see:
>
>     ld: vmlinux.o: in function `x64_sys_call':
>     arch/x86/include/generated/asm/syscalls_64.h:471: undefined reference to `__x64_sys_rseq_slice_yield'
>     ld: vmlinux.o: in function `ia32_sys_call':
>     arch/x86/include/generated/asm/syscalls_32.h:471: undefined reference to `__ia32_sys_rseq_slice_yield'
>     ld: vmlinux.o:(.rodata+0x12d0): undefined reference to `__x64_sys_rseq_slice_yield'
>
> I would have assumed the COND_SYSCALL() above would have stubbed this
> but that doesn't seem to be the case. Am I missing something?

Yes.

>> +COND_SYSCALL(rseq_sched_yield);

does not create a stub for rseq_slice_yield() obviously :)

/me looks for a brown paperbag.


  reply	other threads:[~2025-09-09 12:23 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-08 22:59 [patch 00/12] rseq: Implement time slice extension mechanism Thomas Gleixner
2025-09-08 22:59 ` [patch 01/12] sched: Provide and use set_need_resched_current() Thomas Gleixner
2025-09-08 22:59 ` [patch 02/12] rseq: Add fields and constants for time slice extension Thomas Gleixner
2025-09-09  0:04   ` Randy Dunlap
2025-09-11 15:41   ` Mathieu Desnoyers
2025-09-11 15:49     ` Mathieu Desnoyers
2025-09-22  5:28   ` Prakash Sangappa
2025-09-22  5:57     ` K Prateek Nayak
2025-09-22 13:57       ` Mathieu Desnoyers
2025-09-22 13:55     ` Mathieu Desnoyers
2025-09-23  0:57       ` Prakash Sangappa
2025-09-08 22:59 ` [patch 03/12] rseq: Provide static branch for time slice extensions Thomas Gleixner
2025-09-09  3:10   ` K Prateek Nayak
2025-09-09  4:11     ` Randy Dunlap
2025-09-09 12:12       ` Thomas Gleixner
2025-09-09 16:01         ` Randy Dunlap
2025-09-11 15:42   ` Mathieu Desnoyers
2025-09-08 22:59 ` [patch 04/12] rseq: Add statistics " Thomas Gleixner
2025-09-11 15:43   ` Mathieu Desnoyers
2025-09-08 22:59 ` [patch 05/12] rseq: Add prctl() to enable " Thomas Gleixner
2025-09-11 15:50   ` Mathieu Desnoyers
2025-09-11 16:52     ` K Prateek Nayak
2025-09-11 17:18       ` Mathieu Desnoyers
2025-09-08 23:00 ` [patch 06/12] rseq: Implement sys_rseq_slice_yield() Thomas Gleixner
2025-09-09  9:52   ` K Prateek Nayak
2025-09-09 12:23     ` Thomas Gleixner [this message]
2025-09-10 11:15   ` K Prateek Nayak
2025-09-08 23:00 ` [patch 07/12] rseq: Implement syscall entry work for time slice extensions Thomas Gleixner
2025-09-10  5:22   ` K Prateek Nayak
2025-09-10  7:49     ` Thomas Gleixner
2025-09-08 23:00 ` [patch 08/12] rseq: Implement time slice extension enforcement timer Thomas Gleixner
2025-09-10 11:20   ` K Prateek Nayak
2025-09-08 23:00 ` [patch 09/12] rseq: Reset slice extension when scheduled Thomas Gleixner
2025-09-08 23:00 ` [patch 10/12] rseq: Implement rseq_grant_slice_extension() Thomas Gleixner
2025-09-09  8:14   ` K Prateek Nayak
2025-09-09 12:16     ` Thomas Gleixner
2025-09-08 23:00 ` [patch 11/12] entry: Hook up rseq time slice extension Thomas Gleixner
2025-09-08 23:00 ` [patch 12/12] selftests/rseq: Implement time slice extension test Thomas Gleixner
2025-09-10 11:23   ` K Prateek Nayak
2025-09-09 12:37 ` [patch 00/12] rseq: Implement time slice extension mechanism Thomas Gleixner
2025-09-10  4:42   ` K Prateek Nayak
2025-09-10 11:28 ` K Prateek Nayak
2025-09-10 14:50   ` Thomas Gleixner
2025-09-11  3:03     ` K Prateek Nayak
2025-09-11  7:36       ` Prakash Sangappa
2025-09-11 15:27 ` Mathieu Desnoyers
2025-09-11 20:18   ` Thomas Gleixner
2025-09-12 12:33     ` Mathieu Desnoyers
2025-09-12 16:31       ` Thomas Gleixner
2025-09-12 19:26         ` Mathieu Desnoyers
2025-09-13 13:02           ` Thomas Gleixner
2025-09-19 17:30             ` Prakash Sangappa
2025-09-22 14:09               ` Mathieu Desnoyers
2025-09-23  1:01                 ` Prakash Sangappa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87plbzvmph.ffs@tglx \
    --to=tglx@linutronix.de \
    --cc=arnd@arndb.de \
    --cc=bigeasy@linutronix.de \
    --cc=boqun.feng@gmail.com \
    --cc=corbet@lwn.net \
    --cc=kprateek.nayak@amd.com \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=paulmck@kernel.org \
    --cc=peterz@infradead.org \
    --cc=prakash.sangappa@oracle.com \
    --cc=rostedt@goodmis.org \
    --cc=vineethr@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.