Re: [PATCH] fs/xattr.c: fix simple_xattr_list()

[Collin Funk <collin.funk1@gmail.com>]

Paul Moore <paul@paul-moore.com> writes:

>> <stephen.smalley.work@gmail.com> wrote:
>> >
>> > commit 8b0ba61df5a1 ("fs/xattr.c: fix simple_xattr_list to always
>> > include security.* xattrs") failed to reset err after the call to
>> > security_inode_listsecurity(), which returns the length of the
>> > returned xattr name. This results in simple_xattr_list() incorrectly
>> > returning this length even if a POSIX acl is also set on the inode.
>> >
>> > Reported-by: Collin Funk <collin.funk1@gmail.com>
>> > Closes: https://lore.kernel.org/selinux/8734ceal7q.fsf@gmail.com/
>> > Reported-by: Paul Eggert <eggert@cs.ucla.edu>
>> > Closes: https://bugzilla.redhat.com/show_bug.cgi?id=2369561
>> > Fixes: 8b0ba61df5a1 ("fs/xattr.c: fix simple_xattr_list to always include security.* xattrs")
>> >
>> > Signed-off-by: Stephen Smalley <stephen.smalley.work@gmail.com>
>> > ---
>> >  fs/xattr.c | 1 +
>> >  1 file changed, 1 insertion(+)
>>
>> Reviewed-by: Paul Moore <paul@paul-moore.com>
>
> Resending this as it appears that Stephen's original posting had a
> typo in the VFS mailing list.  The original post can be found in the
> SELinux archives:
>
> https://lore.kernel.org/selinux/20250605164852.2016-1-stephen.smalley.work@gmail.com/

Hi, responding to this message since it has the correct lists.

I just booted into a kernel with this patch applied and confirm that it
fixes the Gnulib tests that were failing.

Reviewed-by: Collin Funk <collin.funk1@gmail.com>
Tested-by: Collin Funk <collin.funk1@gmail.com>

Thanks for the fix.

Collin