All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nathan Lynch <nathan.lynch@amd.com>
To: Eder Zulian <ezulian@redhat.com>, <Basavaraj.Natikar@amd.com>,
	<vkoul@kernel.org>, <dmaengine@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Cc: Eder Zulian <ezulian@redhat.com>
Subject: Re: [PATCH v2] dmaengine: ptdma: Remove unused pointer dma_cmd_cache
Date: Wed, 16 Apr 2025 09:56:36 -0500	[thread overview]
Message-ID: <87plhckvdn.fsf@AUSNATLYNCH.amd.com> (raw)
In-Reply-To: <20250415121312.870124-1-ezulian@redhat.com>

Eder Zulian <ezulian@redhat.com> writes:
> The pointer 'struct kmem_cache *dma_cmd_cache' was introduced in commit
> 'b0b4a6b10577 ("dmaengine: ptdma: register PTDMA controller as a DMA
> resource")' but it was never used.
>
> Changes since v1:
> - Remove the 'err_cache' label and return -ENOMEM directly instead of
>   assigning -ENOMEM to 'ret' and jumping to the label, since there
>   are no unmanaged allocations to unwind. Based on suggestion from
>   Nathan Lynch.
> - Fix checkpatch.pl error: ERROR: Please use git commit description style
>   'commit <12+ chars of sha1> ("<title line>")'
>
> Signed-off-by: Eder Zulian <ezulian@redhat.com>

Reviewed-by: Nathan Lynch <nathan.lynch@amd.com>


  reply	other threads:[~2025-04-16 14:56 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-15 12:13 [PATCH v2] dmaengine: ptdma: Remove unused pointer dma_cmd_cache Eder Zulian
2025-04-16 14:56 ` Nathan Lynch [this message]
2025-04-17  7:35 ` Basavaraj Natikar
2025-04-17 15:18 ` Vinod Koul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87plhckvdn.fsf@AUSNATLYNCH.amd.com \
    --to=nathan.lynch@amd.com \
    --cc=Basavaraj.Natikar@amd.com \
    --cc=dmaengine@vger.kernel.org \
    --cc=ezulian@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.