All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: ye.xingchen@zte.com.cn
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] genirq: Fix parameter type in declaration and definition
Date: Thu, 13 Mar 2025 12:26:28 +0100	[thread overview]
Message-ID: <87plilcgt7.ffs@tglx> (raw)
In-Reply-To: <202503131530063539XBMkqa4y8t8Gbdie-DRn@zte.com.cn>

On Thu, Mar 13 2025 at 15:30, ye xingchen wrote:
> From: YeXingchen <ye.xingchen@zte.com.cn>
>
> The declaration of irq_set_irqchip_state in the header file uses
> bool state as the parameter type, while the definition uses bool val.

What's the problem?

> This patch aligns the parameter name in the definition with the

git grep 'This patch' Documentation/process/

> --- a/kernel/irq/manage.c
> +++ b/kernel/irq/manage.c
> @@ -2860,7 +2860,7 @@ EXPORT_SYMBOL_GPL(irq_get_irqchip_state);
>   *	interrupt controller has per-cpu registers.
>   */
>  int irq_set_irqchip_state(unsigned int irq, enum irqchip_irq_state which,
> -			  bool val)
> +			  bool state)
>  {
>  	struct irq_desc *desc;
>  	struct irq_data *data;

This does not even compile....

So that clearly ensures consistency...

      reply	other threads:[~2025-03-13 11:26 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-13  7:30 [PATCH v2] genirq: Fix parameter type in declaration and definition ye.xingchen
2025-03-13 11:26 ` Thomas Gleixner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87plilcgt7.ffs@tglx \
    --to=tglx@linutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ye.xingchen@zte.com.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.