From: Markus Armbruster <armbru@redhat.com>
To: "Cédric Le Goater" <clg@redhat.com>
Cc: qemu-devel@nongnu.org, Alex Williamson <alex.williamson@redhat.com>
Subject: Re: [PATCH v3 1/7] util/error: Introduce warn_report_err_once()
Date: Tue, 11 Feb 2025 07:53:21 +0100 [thread overview]
Message-ID: <87pljpyntq.fsf@pond.sub.org> (raw)
In-Reply-To: <c7ce5f30-ee52-46c8-b968-08ba01214a3e@redhat.com> ("Cédric Le Goater"'s message of "Mon, 10 Feb 2025 17:26:48 +0100")
Cédric Le Goater <clg@redhat.com> writes:
> On 2/6/25 14:14, Cédric Le Goater wrote:
>> Depending on the configuration of the host and VM, a passthrough
>> device may generate recurring DMA mapping errors at runtime. In such
>> cases, reporting the issue once is sufficient.
>>
>> We have already the warn/error_report_once() routines taking a format
>> and arguments. Using the same design pattern, add a new warning
>> variant taking an 'Error *' parameter.
>>
>> Cc: Markus Armbruster <armbru@redhat.com>
>> Signed-off-by: Cédric Le Goater <clg@redhat.com>
>> ---
>> include/qapi/error.h | 12 ++++++++++++
>> util/error.c | 11 +++++++++++
>> 2 files changed, 23 insertions(+)
>
> Hello Markus,
>
> Are you ok with this change ? Should we take it through the vfio queue ?
Yes, please.
Reviewed-by: Markus Armbruster <armbru@redhat.com>
next prev parent reply other threads:[~2025-02-11 6:53 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-06 13:14 [PATCH v3 0/7] vfio: Improve error reporting when MMIO region mapping fails Cédric Le Goater
2025-02-06 13:14 ` [PATCH v3 1/7] util/error: Introduce warn_report_err_once() Cédric Le Goater
2025-02-10 16:26 ` Cédric Le Goater
2025-02-11 6:53 ` Markus Armbruster [this message]
2025-02-06 13:14 ` [PATCH v3 2/7] vfio/pci: Replace "iommu_device" by "vIOMMU" Cédric Le Goater
2025-02-06 13:14 ` [PATCH v3 3/7] vfio: Rephrase comment in vfio_listener_region_add() error path Cédric Le Goater
2025-02-06 13:14 ` [PATCH v3 4/7] vfio: Introduce vfio_get_vfio_device() Cédric Le Goater
2025-02-06 13:14 ` [PATCH v3 5/7] vfio: Improve error reporting when MMIO region mapping fails Cédric Le Goater
2025-02-06 13:14 ` [PATCH v3 6/7] vfio: Remove reports of DMA mapping errors in backends Cédric Le Goater
2025-02-06 13:14 ` [PATCH v3 7/7] vfio: Remove superfluous error report in vfio_listener_region_add() Cédric Le Goater
2025-02-06 15:07 ` Harsh Prateek Bora
2025-02-10 16:01 ` [PATCH v3 0/7] vfio: Improve error reporting when MMIO region mapping fails Alex Williamson
2025-02-11 13:32 ` Cédric Le Goater
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pljpyntq.fsf@pond.sub.org \
--to=armbru@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=clg@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.