From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 54525E7718C for ; Wed, 18 Dec 2024 10:55:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9LLcmN8IJa3xqN68ff3/fqckCkuUXfLE9pwzAiFUC5M=; b=J5/lLyG2uWsMO+ YGJiQSHrqDa1y0UQFIkYMEpYz1XJVnEjdG+OBCCREf71QGsSo/6mHJqzFgmPsd3s7LYHETpF2ZRvd wiAdUNBLAkmrU4nrybvlJHoLQtaTSuxCManJlGG11NgKI4FOqSrQCLV+uTkWED4ysJcf0+40FSxXG HSUsr8vaDGiDmEzWl2Mdlw77+KHI6HPUTpSjVq9ji/nrIkohbqRdrAzyeltQLuJyHJMICIz4Uwywn RlSLdl8bIMOQxBq32Z62ZBgOLaGytIZRKSaXjkivYVopEBplQ7HitCxinpjin4G5ZG0SCcHkWZ1Wf Sd1Pfim7ALj86DIl8xFQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tNrhv-0000000GLXz-118p; Wed, 18 Dec 2024 10:55:11 +0000 Received: from relay3-d.mail.gandi.net ([217.70.183.195]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tNqRH-0000000G7h7-2kzz for linux-mtd@lists.infradead.org; Wed, 18 Dec 2024 09:33:57 +0000 Received: by mail.gandi.net (Postfix) with ESMTPSA id 87FF760004; Wed, 18 Dec 2024 09:33:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1734514431; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xqsSdcFY6IXV3OPCcBjCkZfAG7HDf4rwQ4pK04TCYsw=; b=ljKA7q9wvwJ/MFe13vh9Pb3DhgR8oAH7Liz2i4z7txpkWRHhfZSNSlLWl/r/lX5bC0iV05 NG68ce8EcWtAN3YzIyAvIJ3ZyyhYpL1LUzfHtthD/2t8iXftNPvIT8hC3iBkBLhHT64urv FM0VHvRNPzq02AMDdbDOEeK42i4CDH/0rNK8Uk552igcz4Anf3qb3V1JRFgvzfzW2G14g+ A2kss3vzjRGozq2aF/NlvUyXWY8JVq2RwqZMfDVDjVeC4taPi/E8CtlhQH//nLmJAiMzA0 3Ta40e+YiJMT9dwpkSGZjiiH9ijVhCRbAO2CJx3qif664MOAgdOH5maYmiiWpg== From: Miquel Raynal To: Tudor Ambarus Cc: Richard Weinberger , Vignesh Raghavendra , Pratyush Yadav , Michael Walle , linux-mtd@lists.infradead.org, Mark Brown , linux-spi@vger.kernel.org, Steam Lin , Thomas Petazzoni , Sanjay R Mehta , Han Xu , Conor Dooley , Daire McNamara , Matthias Brugger , AngeloGioacchino Del Regno , Haibo Chen , Yogesh Gaur , Heiko Stuebner , Michal Simek Subject: Re: [PATCH 23/24] mtd: spinand: winbond: Add comment about naming In-Reply-To: (Tudor Ambarus's message of "Wed, 18 Dec 2024 08:14:36 +0000") References: <20241025161501.485684-1-miquel.raynal@bootlin.com> <20241025161501.485684-24-miquel.raynal@bootlin.com> <71d0cf83-6866-46be-b76f-291a8a6a1346@linaro.org> <87wmg3kbxa.fsf@bootlin.com> User-Agent: mu4e 1.12.7; emacs 29.4 Date: Wed, 18 Dec 2024 10:33:50 +0100 Message-ID: <87pllpe3nl.fsf@bootlin.com> MIME-Version: 1.0 X-GND-Sasl: miquel.raynal@bootlin.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241218_013355_960985_B6E6163C X-CRM114-Status: GOOD ( 16.95 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org T24gMTgvMTIvMjAyNCBhdCAwODoxNDozNiBHTVQsIFR1ZG9yIEFtYmFydXMgPHR1ZG9yLmFtYmFy dXNAbGluYXJvLm9yZz4gd3JvdGU6Cgo+IE9uIDEyLzEzLzI0IDEyOjI1IFBNLCBNaXF1ZWwgUmF5 bmFsIHdyb3RlOgo+PiBPbiAxMS8xMS8yMDI0IGF0IDE0OjM4OjUzIEdNVCwgVHVkb3IgQW1iYXJ1 cyA8dHVkb3IuYW1iYXJ1c0BsaW5hcm8ub3JnPiB3cm90ZToKPj4gCj4+PiBPbiAxMC8yNS8yNCA1 OjE1IFBNLCBNaXF1ZWwgUmF5bmFsIHdyb3RlOgo+Pj4+IE1ha2UgdGhlIGxpbmsgYmV0d2VlbiB0 aGUgY29yZSBtYWNyb3MgYW5kIHRoZSBkYXRhc2hlZXQuCj4+Pj4KPj4+PiBTaWduZWQtb2ZmLWJ5 OiBNaXF1ZWwgUmF5bmFsIDxtaXF1ZWwucmF5bmFsQGJvb3RsaW4uY29tPgo+Pj4+IC0tLQo+Pj4+ ICBkcml2ZXJzL210ZC9uYW5kL3NwaS93aW5ib25kLmMgfCA1ICsrKysrCj4+Pj4gIDEgZmlsZSBj aGFuZ2VkLCA1IGluc2VydGlvbnMoKykKPj4+Pgo+Pj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL210 ZC9uYW5kL3NwaS93aW5ib25kLmMgYi9kcml2ZXJzL210ZC9uYW5kL3NwaS93aW5ib25kLmMKPj4+ PiBpbmRleCA2ODZlODcyZmUwZmYuLjllMjU2MjgwNWQyMyAxMDA2NDQKPj4+PiAtLS0gYS9kcml2 ZXJzL210ZC9uYW5kL3NwaS93aW5ib25kLmMKPj4+PiArKysgYi9kcml2ZXJzL210ZC9uYW5kL3Nw aS93aW5ib25kLmMKPj4+PiBAQCAtMTgsNiArMTgsMTEgQEAKPj4+PiAgCj4+Pj4gICNkZWZpbmUg VzI1TjA0S1ZfU1RBVFVTX0VDQ181XzhfQklURkxJUFMJKDMgPDwgNCkKPj4+PiAgCj4+Pj4gKy8q Cj4+Pj4gKyAqICJYMiIgaW4gdGhlIGNvcmUgaXMgZXF1aXZhbGVudCB0byAiZHVhbCBvdXRwdXQi IGluIHRoZSBkYXRhc2hlZXRzLAo+Pj4+ICsgKiAiWDQiIGluIHRoZSBjb3JlIGlzIGVxdWl2YWxl bnQgdG8gInF1YWQgb3V0cHV0IiBpbiB0aGUgZGF0YXNoZWV0cy4KPj4+PiArICovCj4+Pgo+Pj4g ZG9lc24ndCBoZWxwIGdyZWF0IGZvciBhbiBvdXRzaWRlciBsaWtlIG1lLiBJcyBxdWFkIHJlZmVy cmluZyB0byBjbWQsCj4+PiBhZGRyIG9yIGRhdGE/IE9yIG1heWJlIG9mIGFsbD8gSSBuZWVkIHRv IHJlYWQgdGhlIGNvZGUgYW55d2F5Lgo+PiAKPj4gSSBhbHNvIGRvbid0IGxpa2UgdGhlc2UgdGVy bXMuIElJUkMgIm91dHB1dCIgaXMgcmVmZXJyaW5nIHRvIHRoZSBkYXRhIGN5Y2xlcywKPj4gb3Ro ZXJ3aXNlIGl0IG1lYW5zIGFkZHJlc3MgKGR1bW15KSBhbmQgZGF0YSBjeWNsZXMuCj4+IAo+PiBJ biBzaW5nbGUsIGR1YWwgb3IgcXVhZCBtb2RlIHRoZSBuYW1pbmcgaXMgdW5jbGVhciBidXQgIm9r YXkiLiBCdXQgb2N0YWwKPj4gRERSIG1vZGVzIGNhbiByZXF1aXJlIHRoZSBvcGNvZGUgdG8gYmUg c2VudCBpbiBvY3RhbCBtb2RlIGFzIHdlbGwsIHdoaWNoCj4+IGlzIG5ldy4gSWYgd2Ugc3VwcG9y dCB0aGF0LCBJJ2xsIHRha2UgY2FyZSBvZiB1c2luZyBhIG1vcmUKPj4gdW5kZXJzdGFuZGFibGUg bmFtaW5nIGZvciBhbGwgbWFjcm9zIGxpa2UgWHktWHktWHksIFggYmVpbmcgdGhlCj4+IGJ1c3dp ZHRoLCB5IGJlaW5nIFMgKHNkcikgb3IgRCAoZGRyKSBhbmQgdGhlIHRocmVlIG1lbWJlcnMgYmVp bmcKPgo+IDhkLThkLThkIGlzIGNvbW1vbiBhbmQgY292ZXJlZCBieSBmZXcgc3RhbmRhcmRzLCB5 ZXMuCj4KPj4gQ29tbWFuZC1BZGRyZXNzLURhdGEuIEkgbWlnaHQgZXZlbiBiZSB0ZW1wdGVkIHRv IGluY2x1ZGUgZHVtbXkgY3ljbGVzIGFzCj4+IHdlbGwsIGJlY2F1c2UgaXQgaXMgaW1wb3J0YW50 IHRvIGJlIGNsZWFyIGlmIGVnLiBpbiBvY3RhbCBtb2RlICIxIiBtZWFucwo+PiAiMSBjeWNsZSIg b3IgIjggY3ljbGVzIi4KPiBJIGZpbmQgdGhlIGluZm8gYWJvdXQgZHVtbXkgY3ljbGVzIHVzZWZ1 bC4gSSB3b25kZXIgaWYgc3VjaCB0ZXJtaW5vbG9neQo+IGlzIGFscmVhZHkgc3BlY2lmaWVkIGlu IGEgc3RhbmRhcmQuIElmIG5vdCwgbWF5YmUgd2UgY2FuIHB1dCB0aGUgZHVtbXkKPiBjeWNsZXMg YWZ0ZXIgdGhlIG1vZGUsIGluIHBhcmVudGhlc2lzPyBJIHdvdWxkIHJlZnJhaW4gY3VzdG9tIHRl cm1pbm9sb2d5LgoKSSBzZWUgeW91IGNvbmNlcm4sIGJ1dCB3b3VsZCB5b3UgbWluZCBnaXZpbmcg YW4gZXhhbXBsZSBvZiB3aGF0IHlvdSBoYXZlCmluIG1pbmQ/CgpUaGFua3MsCk1pcXXDqGwKCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpMaW51 eCBNVEQgZGlzY3Vzc2lvbiBtYWlsaW5nIGxpc3QKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcv bWFpbG1hbi9saXN0aW5mby9saW51eC1tdGQvCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [217.70.183.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C40CC19CD01 for ; Wed, 18 Dec 2024 09:33:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.183.195 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734514443; cv=none; b=I2DIvr7yaY7eU0LeBNIdY4LqmI5Qq/SpHdLQuP3npv/agyiW4njxF1SqFDu0e9/BUcsOL/1nGb1cNr/EZbp61WaCWtUPauB2tfeGTH+1oM2hdRJn7dXhGb7efcyqOgF8MrRU8eFMtbpfSaKY6U0VcGHA6MeSe2svxSP7/qD+cBQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734514443; c=relaxed/simple; bh=N+yudQqu3EweGcHwQ5gLqs3DR+1G67EJPTe2nZcPmGs=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=Uoc4PFeuNgN/tsdzR3aXSmWQd+Um765pd1SI1bE0J3GChmqwVdXnfIEztzLC/D7p25fjo5unBxy/fPnnfseXWl83rcxWZW7cRZM82HYdzMM0Swaj5lpAciTi9n2i5fZyJ0HYkghRsr0ctDs9yHXmb/pbqi9v8EV0lVcGiNLZhIs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=ljKA7q9w; arc=none smtp.client-ip=217.70.183.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="ljKA7q9w" Received: by mail.gandi.net (Postfix) with ESMTPSA id 87FF760004; Wed, 18 Dec 2024 09:33:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1734514431; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xqsSdcFY6IXV3OPCcBjCkZfAG7HDf4rwQ4pK04TCYsw=; b=ljKA7q9wvwJ/MFe13vh9Pb3DhgR8oAH7Liz2i4z7txpkWRHhfZSNSlLWl/r/lX5bC0iV05 NG68ce8EcWtAN3YzIyAvIJ3ZyyhYpL1LUzfHtthD/2t8iXftNPvIT8hC3iBkBLhHT64urv FM0VHvRNPzq02AMDdbDOEeK42i4CDH/0rNK8Uk552igcz4Anf3qb3V1JRFgvzfzW2G14g+ A2kss3vzjRGozq2aF/NlvUyXWY8JVq2RwqZMfDVDjVeC4taPi/E8CtlhQH//nLmJAiMzA0 3Ta40e+YiJMT9dwpkSGZjiiH9ijVhCRbAO2CJx3qif664MOAgdOH5maYmiiWpg== From: Miquel Raynal To: Tudor Ambarus Cc: Richard Weinberger , Vignesh Raghavendra , Pratyush Yadav , Michael Walle , linux-mtd@lists.infradead.org, Mark Brown , linux-spi@vger.kernel.org, Steam Lin , Thomas Petazzoni , Sanjay R Mehta , Han Xu , Conor Dooley , Daire McNamara , Matthias Brugger , AngeloGioacchino Del Regno , Haibo Chen , Yogesh Gaur , Heiko Stuebner , Michal Simek Subject: Re: [PATCH 23/24] mtd: spinand: winbond: Add comment about naming In-Reply-To: (Tudor Ambarus's message of "Wed, 18 Dec 2024 08:14:36 +0000") References: <20241025161501.485684-1-miquel.raynal@bootlin.com> <20241025161501.485684-24-miquel.raynal@bootlin.com> <71d0cf83-6866-46be-b76f-291a8a6a1346@linaro.org> <87wmg3kbxa.fsf@bootlin.com> User-Agent: mu4e 1.12.7; emacs 29.4 Date: Wed, 18 Dec 2024 10:33:50 +0100 Message-ID: <87pllpe3nl.fsf@bootlin.com> Precedence: bulk X-Mailing-List: linux-spi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-GND-Sasl: miquel.raynal@bootlin.com On 18/12/2024 at 08:14:36 GMT, Tudor Ambarus wro= te: > On 12/13/24 12:25 PM, Miquel Raynal wrote: >> On 11/11/2024 at 14:38:53 GMT, Tudor Ambarus = wrote: >>=20 >>> On 10/25/24 5:15 PM, Miquel Raynal wrote: >>>> Make the link between the core macros and the datasheet. >>>> >>>> Signed-off-by: Miquel Raynal >>>> --- >>>> drivers/mtd/nand/spi/winbond.c | 5 +++++ >>>> 1 file changed, 5 insertions(+) >>>> >>>> diff --git a/drivers/mtd/nand/spi/winbond.c b/drivers/mtd/nand/spi/win= bond.c >>>> index 686e872fe0ff..9e2562805d23 100644 >>>> --- a/drivers/mtd/nand/spi/winbond.c >>>> +++ b/drivers/mtd/nand/spi/winbond.c >>>> @@ -18,6 +18,11 @@ >>>>=20=20 >>>> #define W25N04KV_STATUS_ECC_5_8_BITFLIPS (3 << 4) >>>>=20=20 >>>> +/* >>>> + * "X2" in the core is equivalent to "dual output" in the datasheets, >>>> + * "X4" in the core is equivalent to "quad output" in the datasheets. >>>> + */ >>> >>> doesn't help great for an outsider like me. Is quad referring to cmd, >>> addr or data? Or maybe of all? I need to read the code anyway. >>=20 >> I also don't like these terms. IIRC "output" is referring to the data cy= cles, >> otherwise it means address (dummy) and data cycles. >>=20 >> In single, dual or quad mode the naming is unclear but "okay". But octal >> DDR modes can require the opcode to be sent in octal mode as well, which >> is new. If we support that, I'll take care of using a more >> understandable naming for all macros like Xy-Xy-Xy, X being the >> buswidth, y being S (sdr) or D (ddr) and the three members being > > 8d-8d-8d is common and covered by few standards, yes. > >> Command-Address-Data. I might even be tempted to include dummy cycles as >> well, because it is important to be clear if eg. in octal mode "1" means >> "1 cycle" or "8 cycles". > I find the info about dummy cycles useful. I wonder if such terminology > is already specified in a standard. If not, maybe we can put the dummy > cycles after the mode, in parenthesis? I would refrain custom terminology. I see you concern, but would you mind giving an example of what you have in mind? Thanks, Miqu=C3=A8l