From: "Ritesh Harjani (IBM)" <ritesh.list@gmail.com>
To: Madhavan Srinivasan <maddy@linux.ibm.com>,
mpe@ellerman.id.au, npiggin@gmail.com,
christophe.leroy@csgroup.eu, naveen@kernel.org, shuah@kernel.org
Cc: linuxppc-dev@lists.ozlabs.org, linux-kselftest@vger.kernel.org,
Madhavan Srinivasan <maddy@linux.ibm.com>
Subject: Re: [PATCH 1/3] selftest/powerpc/ptrace/core-pkey: Remove duplicate macros
Date: Mon, 16 Dec 2024 16:17:56 +0530 [thread overview]
Message-ID: <87pllr52g3.fsf@gmail.com> (raw)
In-Reply-To: <20241209151418.348085-1-maddy@linux.ibm.com>
Madhavan Srinivasan <maddy@linux.ibm.com> writes:
> core-pkey.c test has couple of macros defined which
> are part of "pkeys.h" header file. Remove those
> duplicates and include "pkeys.h"
>
> Signed-off-by: Madhavan Srinivasan <maddy@linux.ibm.com>
> ---
> .../selftests/powerpc/ptrace/core-pkey.c | 19 +------------------
> 1 file changed, 1 insertion(+), 18 deletions(-)
.../powerpc/ptrace/Makefile includes flags.mk. In
.../powerpc/flags.mk we anyways add -I$(selfdir)/powerpc/include in
CFLAGS - so it will pick up the header files defined in powerpc/include.
It make sense to clean this up and consolidate the common header definitions
into pkeys.h header file. The changes looks good to me. Please feel free
to add -
Reviewed-by: Ritesh Harjani (IBM) <ritesh.list@gmail.com>
-ritesh
next prev parent reply other threads:[~2024-12-16 10:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-09 15:14 [PATCH 1/3] selftest/powerpc/ptrace/core-pkey: Remove duplicate macros Madhavan Srinivasan
2024-12-09 15:14 ` [PATCH 2/3] selftest/powerpc/ptrace/ptrace-pkey: " Madhavan Srinivasan
2024-12-16 10:54 ` Ritesh Harjani
2024-12-16 12:09 ` Madhavan Srinivasan
2024-12-09 15:14 ` [PATCH 3/3] selftest/powerpc/ptrace: Cleanup duplicate macro definitions Madhavan Srinivasan
2024-12-16 10:57 ` Ritesh Harjani
2024-12-16 12:09 ` Madhavan Srinivasan
2024-12-16 10:47 ` Ritesh Harjani (IBM) [this message]
2024-12-16 12:10 ` [PATCH 1/3] selftest/powerpc/ptrace/core-pkey: Remove duplicate macros Madhavan Srinivasan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pllr52g3.fsf@gmail.com \
--to=ritesh.list@gmail.com \
--cc=christophe.leroy@csgroup.eu \
--cc=linux-kselftest@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maddy@linux.ibm.com \
--cc=mpe@ellerman.id.au \
--cc=naveen@kernel.org \
--cc=npiggin@gmail.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.