All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Yongzhen Zhang <zhangyongzhen@kylinos.cn>
Cc: perex@perex.cz, tiwai@suse.com, linux-sound@vger.kernel.org,
	kailang@realtek.com
Subject: Re: [PATCH] ALSA: hda/realtek: Remove needless comment lines
Date: Wed, 04 Dec 2024 10:43:32 +0100	[thread overview]
Message-ID: <87plm7wzp7.wl-tiwai@suse.de> (raw)
In-Reply-To: <20241204093928.15988-1-zhangyongzhen@kylinos.cn>

On Wed, 04 Dec 2024 10:39:28 +0100,
Yongzhen Zhang wrote:
> 
> -/*
> - */
> -

Too cryptic description :)

And, instead of removing, better to put proper comment instead.


thanks,

Takashi

> 
> Signed-off-by: Yongzhen Zhang <zhangyongzhen@kylinos.cn>
> ---
>  sound/pci/hda/patch_realtek.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index 4ba9e647250b..b73b1a51a23d 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -890,9 +890,6 @@ static void alc_ssid_check(struct hda_codec *codec, const hda_nid_t *ports)
>  	}
>  }
>  
> -/*
> - */
> -
>  static void alc_fixup_inv_dmic(struct hda_codec *codec,
>  			       const struct hda_fixup *fix, int action)
>  {
> -- 
> 2.34.1
> 

  reply	other threads:[~2024-12-04  9:43 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-04  9:39 [PATCH] ALSA: hda/realtek: Remove needless comment lines Yongzhen Zhang
2024-12-04  9:43 ` Takashi Iwai [this message]
2024-12-23  8:47   ` [PATCH v2] ALSA: hda/realtek: Add a comment for alc_fixup_inv_dmic() Yongzhen Zhang
2024-12-29  8:21     ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87plm7wzp7.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=kailang@realtek.com \
    --cc=linux-sound@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.com \
    --cc=zhangyongzhen@kylinos.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.