From: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Wang Jianjian <wangjianjian3@huawei.com>,
<linux-kernel@vger.kernel.org>, <wangjianjian0@foxmail.com>
Subject: Re: [PATCH] fat: use nls_tolower simplify code
Date: Thu, 28 Nov 2024 13:52:24 +0900 [thread overview]
Message-ID: <87plmg9czb.fsf@mail.parknet.co.jp> (raw)
In-Reply-To: <20241128031234.3668274-1-wangjianjian3@huawei.com> (Wang Jianjian's message of "Thu, 28 Nov 2024 11:12:34 +0800")
Wang Jianjian <wangjianjian3@huawei.com> writes:
> Signed-off-by: Wang Jianjian <wangjianjian3@huawei.com>
Looks good. Thanks.
Acked-by: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
> ---
> fs/fat/dir.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/fs/fat/dir.c b/fs/fat/dir.c
> index acbec5bdd521..88bf16204aab 100644
> --- a/fs/fat/dir.c
> +++ b/fs/fat/dir.c
> @@ -214,10 +214,7 @@ fat_short2lower_uni(struct nls_table *t, unsigned char *c,
> *uni = 0x003f; /* a question mark */
> charlen = 1;
> } else if (charlen <= 1) {
> - unsigned char nc = t->charset2lower[*c];
> -
> - if (!nc)
> - nc = *c;
> + unsigned char nc = nls_tolower(t, *c);
>
> charlen = t->char2uni(&nc, 1, uni);
> if (charlen < 0) {
--
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
next prev parent reply other threads:[~2024-11-28 4:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-28 3:12 [PATCH] fat: use nls_tolower simplify code Wang Jianjian
2024-11-28 4:52 ` OGAWA Hirofumi [this message]
2024-11-28 16:55 ` Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87plmg9czb.fsf@mail.parknet.co.jp \
--to=hirofumi@mail.parknet.co.jp \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wangjianjian0@foxmail.com \
--cc=wangjianjian3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.