From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 04871D6ED04 for ; Thu, 21 Nov 2024 11:20:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:MIME-Version: Message-ID:In-Reply-To:Date:References:Subject:Cc:To:From:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=IA//c55dlkYzyi5gb2SuOsamA25SXLdOFWy12IJhr7s=; b=qs+xDxC//FPWx9xWRM5uQEdp1I dvE+twwWmflYDuzFEmFzKhKGcldSorvtrp1iJ9cWentcroW85AyiExvys0mEytOGAPxTUt+b9Fc1O Iy7u8wg9PPXAeA8CGdlgGezzNVqpbQcJeWLNL0xn4+Sni/5wBtZQB3KCcR5DS/ZhXtq6v9uocG8Oe diCymwGhWTs+SXwxNbUjZ3M/CSnZ0Nyof9ULtqLB8pNvUwaLDJ7LdRh76EkWoS3fuemk7UyBgidyF 7jzbRFCjMnOZh+Pi5xV21gY55iKZtnWkO/Xcr0npC/PhhQSVtcwoj9pzk2R13eS0AGkhbUi0775Dc g1efOmIw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tE5Ew-0000000HS6q-2tBO; Thu, 21 Nov 2024 11:20:50 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tE5Eu-0000000HS5a-1PVK for ath11k@lists.infradead.org; Thu, 21 Nov 2024 11:20:49 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id D380D5C573F; Thu, 21 Nov 2024 11:20:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1E5FEC4CECC; Thu, 21 Nov 2024 11:20:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1732188047; bh=V1qwmYpUnP1CiJot/3EBrHXVUBv8JOAa6S7kT+VjG8M=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=HAp+d4bVQao54y/cn2DsJqZy9Yb14gtl7gGMwhxXfbV26TwD7zGxFVlX86SoLzAoP AWJ1CVS3QD9B3lZGgOOvGpLtIbRyRhdCVxr3k1pF42aRFCoTsfAr5iCQwZcCpJ1cMK 2VIU4X1uR2iQUj055G2YcsfFotF3WZK9XNVnWw/ZnS2QQob915sBVMpxpeAglEaCSz KY77A1Mv9lR3KwElj0G9LBb/AWeo9vmLThlaRMnv98rb9RPQ7aPbFeFWMiTwHZytpC Ici219Mz2XWVLuB9R7tkcPmD/k5W/MMHuXRSGTVeLMl8X5Jq2kx+UrQMfo1eEviU9s Gblr7G0UBxW5A== From: Kalle Valo To: Jeff Johnson Cc: Jeff Johnson , "Nathan Chancellor" , Nick Desaulniers , Bill Wendling , Justin Stitt , "Arnd Bergmann" , , , , Subject: Re: [PATCH 3/3] wifi: ath11k: mark ath11k_wow_convert_8023_to_80211() as noinline References: <20241119-ath11k-noinline-v1-0-4ec0a8aa30b2@quicinc.com> <20241119-ath11k-noinline-v1-3-4ec0a8aa30b2@quicinc.com> Date: Thu, 21 Nov 2024 13:20:43 +0200 In-Reply-To: <20241119-ath11k-noinline-v1-3-4ec0a8aa30b2@quicinc.com> (Jeff Johnson's message of "Tue, 19 Nov 2024 07:47:40 -0800") Message-ID: <87plmox27o.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241121_032048_416921_40817B03 X-CRM114-Status: GOOD ( 10.31 ) X-BeenThere: ath11k@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "ath11k" Errors-To: ath11k-bounces+ath11k=archiver.kernel.org@lists.infradead.org Jeff Johnson writes: > When compiling the ath11k driver using clang with KASAN enabled, the > following warning is observed: > > drivers/net/wireless/ath/ath11k/wow.c:672:5: warning: stack frame size (1336) exceeds limit (1024) in 'ath11k_wow_op_suspend' [-Wframe-larger-than] > > This is similar to the issue found in ath12k/qmi.c that was discussed > in [1] and fixed with [2]. The issue is that clang inlining can > explode stack usage. > > ath11k_wow_op_suspend() itself is a pretty lightweight function, but > it dispatches to several other functions which do the real work. One > path in particular is: > > ath11k_wow_op_suspend() > ath11k_wow_set_wakeups() > ath11k_vif_wow_set_wakeups() > ath11k_wow_convert_8023_to_80211() > > Of these, ath11k_wow_convert_8023_to_80211() has non-trivial stack > usage, so mark it as 'noinline_for_stack' to prevent it from being > inlined in ath11k_wow_op_suspend(), thereby eliminating the excessive > stack usage. > > Link: https://msgid.link/bc214795-1c51-4cb7-922f-67d6ef98bff2@quicinc.com # [1] > Link: https://patch.msgid.link/20241028-ath12k_qmi_driver_event_work-v1-1-0d532eb593fa@quicinc.com # [2] > Signed-off-by: Jeff Johnson Acked-by: Kalle Valo -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches