From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4A68BCE7AE8 for ; Fri, 6 Sep 2024 08:47:29 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id ABC7D10E9C5; Fri, 6 Sep 2024 08:47:28 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; secure) header.d=linutronix.de header.i=@linutronix.de header.b="jmHTdtdU"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="p4EvLS17"; dkim-atps=neutral Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3B42610E9C5 for ; Fri, 6 Sep 2024 08:47:27 +0000 (UTC) From: John Ogness DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1725612445; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Oa8B0exPuHorkfb3VBgoef687xB6sMs73RRCB0C9WhI=; b=jmHTdtdUGvZY4c5xEMGMPt8nSh9czuB7Jj3l9qfv9EQigYmGn3Ie9SEOdanBnAHuPojb7l hUgVGAdt7WpDxjVkLzCObUOrc4wsqiVEURn3vfiVd+CKSgRCsnrN9ecA94HQbkIFgi1Hr9 NlDzC73sZikE6Er/v5CtxHroxj8eNasoNl+SmnxIYVbu4xuSS1PwNy/56spFcGxTpi10oj 3alpK/SvjsKYfNSt8ACVCEhta4rwCvERxeFiwfSADG5TwSM85dcyBt2QhOCX9TS7alaP6V Ruwd63raIZjTRYXFDwOQj3yBsIdr5UY0vqEWeFFJ3SXDmGRlN3tHPj60/CZuxg== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1725612445; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Oa8B0exPuHorkfb3VBgoef687xB6sMs73RRCB0C9WhI=; b=p4EvLS17dbTj5Ob8xY8Oe8RB2BbwrpnLWY2cdQDAt6u+h2mzS9aSCA82XaY0xA2fN/usUZ PBAoxx6bWkAvNkBA== To: Jocelyn Falempe , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Javier Martinez Canillas , "Guilherme G . Piccoli" , bluescreen_avenger@verizon.net, Petr Mladek , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 3/3] drm/log: Introduce a new boot logger to draw the kmsg on the screen In-Reply-To: <87seudchlu.fsf@jogness.linutronix.de> References: <20240801100640.462606-1-jfalempe@redhat.com> <20240801100640.462606-4-jfalempe@redhat.com> <87o76czfb2.fsf@jogness.linutronix.de> <87zfpwxqpc.fsf@jogness.linutronix.de> <87a5gm2khw.fsf@jogness.linutronix.de> <87seudchlu.fsf@jogness.linutronix.de> Date: Fri, 06 Sep 2024 10:53:25 +0206 Message-ID: <87plphcgo2.fsf@jogness.linutronix.de> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 2024-09-06, John Ogness wrote: > Your device_lock()/device_unlock() callbacks probably just need to > lock/unlock your mutex @drm_log_lock. Sorry, forgot to mention that the device_lock() callback must also disable migration. Since you are using a mutex, you will need to manually do that as well... mutex_lock(&drm_log_lock); migrate_disable(); John