From: Jonathan Corbet <corbet@lwn.net>
To: Michal Wajdeczko <michal.wajdeczko@intel.com>, linux-doc@vger.kernel.org
Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>,
Rae Moar <rmoar@google.com>
Subject: Re: [PATCH] kernel-doc: Allow whitespace before comment start
Date: Thu, 05 Sep 2024 13:56:43 -0600 [thread overview]
Message-ID: <87plphho1w.fsf@trenco.lwn.net> (raw)
In-Reply-To: <20240829202529.1660-1-michal.wajdeczko@intel.com>
Michal Wajdeczko <michal.wajdeczko@intel.com> writes:
> There is some existing documentation that is formatted with some
> indent at the beginning (like one in include/kunit/visibility.h).
>
> However, such notation is not recognized by the script and attempt
> to include that in kernel documentation fails with:
>
> ../include/kunit/visibility.h:1: warning: no structured comments found
>
> Change the doc_start regex to also match /** with some whitespaces
> at beginning of the line.
>
> Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
> ---
> Cc: Jonathan Corbet <corbet@lwn.net>
> Cc: Rae Moar <rmoar@google.com>
> ---
> scripts/kernel-doc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
This patch adds vast numbers of build errors and warnings; did you try a
build with it?
jon
next prev parent reply other threads:[~2024-09-05 19:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-29 20:25 [PATCH] kernel-doc: Allow whitespace before comment start Michal Wajdeczko
2024-09-05 19:56 ` Jonathan Corbet [this message]
2024-09-05 22:43 ` Michal Wajdeczko
2024-09-06 13:49 ` Jonathan Corbet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87plphho1w.fsf@trenco.lwn.net \
--to=corbet@lwn.net \
--cc=linux-doc@vger.kernel.org \
--cc=michal.wajdeczko@intel.com \
--cc=rmoar@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.