All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: John Stultz <jstultz@google.com>, LKML <linux-kernel@vger.kernel.org>
Cc: John Stultz <jstultz@google.com>, Stephen Boyd <sboyd@kernel.org>,
	Anna-Maria Behnsen <anna-maria@linutronix.de>,
	Frederic Weisbecker <frederic@kernel.org>
Subject: Re: [PATCH] time: Rename CLOCK_SET_* as BASEMASK_*_CLOCK_SET
Date: Mon, 02 Sep 2024 17:45:57 +0200	[thread overview]
Message-ID: <87plpm5aa2.ffs@tglx> (raw)
In-Reply-To: <20240815200325.2474604-1-jstultz@google.com>

On Thu, Aug 15 2024 at 13:03, John Stultz wrote:
> In commit 5916be8a53de ("timekeeping: Fix bogus clock_was_set()
> invocation in do_adjtimex()"), Thomas fixed a bug where instead
> of passing one of the CLOCK_SET_* values to clock_was_set(),a
> conceptually related clockid (CLOCK_REALTIME) was incorrectly
> passed.
>
> Just to make this type of accident less likely, lets rename the

s/lets//

> base masks used by clock_was_set() to something that doesn't
> resemble a clockid.
>
> Thus:
> CLOCK_SET_WALL -> BASEMASK_WALL_CLOCK_SET
> CLOCK_SET_BOOT -> BASEMASK_BOOT_CLOCK_SET

I don't think that's the actual problem. What's the confusing part is
the function name itself clock_was_set().

Renaming that to at the same time to something unambiguous would be
helpful.

hrtimer_refresh_bases() or something like that should be descriptive
enough.

Thanks,

        tglx



      reply	other threads:[~2024-09-02 15:45 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-03 15:07 [PATCH] timekeeping: Fix bogus clock_was_set() invocation in do_adjtimex() Thomas Gleixner
2024-08-05 14:22 ` [tip: timers/urgent] " tip-bot2 for Thomas Gleixner
2024-08-05 17:50 ` [PATCH] " John Stultz
2024-08-05 18:30   ` Thomas Gleixner
2024-08-15 20:03     ` [PATCH] time: Rename CLOCK_SET_* as BASEMASK_*_CLOCK_SET John Stultz
2024-09-02 15:45       ` Thomas Gleixner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87plpm5aa2.ffs@tglx \
    --to=tglx@linutronix.de \
    --cc=anna-maria@linutronix.de \
    --cc=frederic@kernel.org \
    --cc=jstultz@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sboyd@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.