From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2F93ECA0ED3 for ; Mon, 2 Sep 2024 14:21:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To:Subject:Cc: To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=eR5gk8P92bj0WWLAHDEjDFbFY/1Fn7KR6G8p3+cXr2M=; b=rynupEi6bPi/UfCsywklyYyQp4 566Wycl9fc1xXjH+OqKcVlfu7ylJE2LcgmcpTpKTeVTfgnZF9TePn+fhHNCtHCfgEpmhcCSXZtnlv zxW+U2zKd/2e+dPz7wPmI/YBvuBWin82QXXgUGvyJtuSF6atdKby2l07bMd9yEMIJ9sCHUXIgyrLe WseX/n44u9WH3wQzS3FuB6bzOgkBjVAff8McWNlIowM2W6he1ZrV/w2buihE2BjUrYcDZb8DtERTg luRMYiV7v/dLp68ZZKwHZfzvUojXqho9E+n2xl30qES1KQS5RKoaSBe7AlsMaU0njMJOxHIEqmAGO SGkO5isg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sl7vp-0000000Ee1A-3wWk; Mon, 02 Sep 2024 14:21:25 +0000 Received: from relay4-d.mail.gandi.net ([217.70.183.196]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sl7uv-0000000Edo9-3UXG for linux-arm-kernel@lists.infradead.org; Mon, 02 Sep 2024 14:20:31 +0000 Received: by mail.gandi.net (Postfix) with ESMTPSA id 7C70AE0018; Mon, 2 Sep 2024 14:19:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1725286826; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eR5gk8P92bj0WWLAHDEjDFbFY/1Fn7KR6G8p3+cXr2M=; b=DMentESz9v6no8zt/aYUTlGtVrE5TErmw2grdbYXjXwVYigWyiWzKgKBxN62FIVIgMq3zA C89ajn2Eb3r3DG/d/LAdPaHjYzfvdrcix/KgWBszLPMYV4oZZQfBfasIDRkOUPTSNElEk7 u64e5DVnGAIEQJxrCVz6uoMZUB7R77AC4wghAcmz7KVJjiAO3m4HMW5SnjtloZpgeYIoO9 FqloInZoi8cNFKrqbgxUUoFZhGsG2AzPCkfAI4KOL+GGtqKOveyFiGy6wwpWBkjTqdvteI Sbe7Yyf4TcLpwkCOJTJnnEFgKhSh1zV49mqF6cm1Lf2MWCZqf5NzZDOj5YeZQg== From: Gregory CLEMENT To: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , Andrew Lunn , Sebastian Hesselbarth , Jason Cooper Cc: linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] ARM: dove: Drop a write-only variable In-Reply-To: <20240708092352.1358438-2-u.kleine-koenig@baylibre.com> References: <20240708092352.1358438-2-u.kleine-koenig@baylibre.com> Date: Mon, 02 Sep 2024 16:19:47 +0200 Message-ID: <87plpmf88s.fsf@BLaptop.bootlin.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-GND-Sasl: gregory.clement@bootlin.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240902_072030_023334_51787B10 X-CRM114-Status: GOOD ( 13.46 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Uwe , > This fixes a W=3D1 build error: > > arch/arm/mach-dove/common.c: In function =E2=80=98dove_clk_init=E2=80=99: > arch/arm/mach-dove/common.c:85:40: error: variable =E2=80=98gephy=E2=80= =99 set but not used [-Werror=3Dunused-but-set-variable] > 85 | struct clk *xor0, *xor1, *ge, *gephy; > | ^~~~~ > > Fixes: 521674718af0 ("ARM: dove: add clock gating control") > Signed-off-by: Uwe Kleine-K=C3=B6nig Applied on mvebu/arm Thanks, Gregory > --- > arch/arm/mach-dove/common.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/mach-dove/common.c b/arch/arm/mach-dove/common.c > index 3aea90bbb41a..35e978514591 100644 > --- a/arch/arm/mach-dove/common.c > +++ b/arch/arm/mach-dove/common.c > @@ -82,7 +82,7 @@ static void __init dove_clk_init(void) > { > struct clk *usb0, *usb1, *sata, *pex0, *pex1, *sdio0, *sdio1; > struct clk *nand, *camera, *i2s0, *i2s1, *crypto, *ac97, *pdma; > - struct clk *xor0, *xor1, *ge, *gephy; > + struct clk *xor0, *xor1, *ge; >=20=20 > tclk =3D clk_register_fixed_rate(NULL, "tclk", NULL, 0, dove_tclk); >=20=20 > @@ -102,7 +102,7 @@ static void __init dove_clk_init(void) > pdma =3D dove_register_gate("pdma", "tclk", CLOCK_GATING_BIT_PDMA); > xor0 =3D dove_register_gate("xor0", "tclk", CLOCK_GATING_BIT_XOR0); > xor1 =3D dove_register_gate("xor1", "tclk", CLOCK_GATING_BIT_XOR1); > - gephy =3D dove_register_gate("gephy", "tclk", CLOCK_GATING_BIT_GIGA_PHY= ); > + dove_register_gate("gephy", "tclk", CLOCK_GATING_BIT_GIGA_PHY); > ge =3D dove_register_gate("ge", "gephy", CLOCK_GATING_BIT_GBE); >=20=20 > orion_clkdev_add(NULL, "orion_spi.0", tclk); > > base-commit: 0b58e108042b0ed28a71cd7edf5175999955b233 > --=20 > 2.43.0