Re: [Buildroot] [PATCH 1/1] package/coreutils: fix glibc build with gcc >= 14

From: Peter Korsgaard <peter@korsgaard.com>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/coreutils: fix glibc build with gcc >= 14
Date: Sat, 31 Aug 2024 18:46:46 +0200	[thread overview]
Message-ID: <87plpoy70p.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20240722220922.590401-1-fontaine.fabrice@gmail.com> (Fabrice Fontaine's message of "Tue, 23 Jul 2024 00:09:22 +0200")

>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:

 > ac_cv_func_strerror_r_char_p is hardcoded to no since commit
 > 74b9bf9945921a7b0504b4b546a4bc26f2adcc45 back in 2005 however strerror_r
 > only returns an int with musl. With glibc or uclibc, strerror_r returns
 > a char* or an int depending on _GNU_SOURCE value resulting in the
 > following build failure with gcc >= 14:

 > strerror_r.c: In function 'rpl_strerror_r':
 > strerror_r.c:207:9: error: assignment to 'int' from 'char *' makes integer from pointer without a cast [-Wint-conversion]
 >   207 |     ret = strerror_r (errnum, buf, buflen);
 >       |         ^

 > To fix this build failure, don't hardcode ac_cv_func_strerror_r_char_p
 > to let coreutils pick the correct value

 > Fixes:
 >  - http://autobuild.buildroot.org/results/8bc649ca5490b0c29c90383edfa2e693f154ebc4

 > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Committed to 2024.05.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot