From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Gleixner Date: Wed, 14 Aug 2024 17:06:14 +0200 Subject: [PATCH v2 2/2] irqchip/aspeed-intc: Add support for AST27XX INTC In-Reply-To: <20240814114106.2809876-4-kevin_chen@aspeedtech.com> References: <20240814114106.2809876-1-kevin_chen@aspeedtech.com> <20240814114106.2809876-4-kevin_chen@aspeedtech.com> Message-ID: <87plqbnnyx.ffs@tglx> List-Id: To: linux-aspeed@lists.ozlabs.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Wed, Aug 14 2024 at 19:41, Kevin Chen wrote: > Support for the Aspeed Interrupt Controller found on Aspeed Silicon SoCs, > such as the AST2700, which is arm64 architecture. > > To support ASPEED interrupt controller(INTC) maps the internal interrupt > sources of the AST27XX device to an parent interrupt controller. This still lacks a Signed-off-by: tag and my comment about the error path in the init function is still valid. Do you think that addressing review feedback is optional? Feel free to ignore it, but don't be surprised if I ignore further patches from you. Take your time and go through stuff properly and do not rush out half baked patches in a frenzy. Thanks, tglx From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 84029C3DA4A for ; Wed, 14 Aug 2024 16:15:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:MIME-Version: Message-ID:Date:References:In-Reply-To:Subject:To:From:Reply-To:Cc: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=kgBDpLd5CRpFg6iGANviJjQZYBMsab2XfI71ntFAp9M=; b=LwY+gVkqaEAPvZsRKoesjqXWZX wJbEB+mJeF5fRGRU0Pj1Q4lqmdfDQOEwTxVxuZvcun6EodknPPSJLZNwPC7trPPg9SSSIqHBRC4sk z7tVl05bMcOrvQahVWpZxea6kpeYBw8QoUTWsIyuMTAvtu+6XC4z+3iZ4ShDAlshjbGoi9UBa81ZU gWeyG08W6Q/yM+/sCZST1KYv7MMj51DdBgdP6mIb+eTdfiyCYzgHo/1C7sITjKss7ok2WeSgbFL5J aNP1NJCvQc1KvzAzlSXZfd2MU2oLGvN2LqxL5a5V+1YoeM5frcoW0jnVl/CDuMKIHWKhGQdQO8Xb1 uXMOoH2A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1seGf6-00000007cXm-1U46; Wed, 14 Aug 2024 16:15:48 +0000 Received: from galois.linutronix.de ([193.142.43.55]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1seFZo-00000007QAn-0rP0 for linux-arm-kernel@lists.infradead.org; Wed, 14 Aug 2024 15:06:20 +0000 From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1723647974; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=kgBDpLd5CRpFg6iGANviJjQZYBMsab2XfI71ntFAp9M=; b=tAiYKLbkjpo3vw7vm6WQ5c7NaedPhBkRMhEoTNaEjtTBNkJoxXr6ch7ieW7REJBS8Bs0bI MFa+tPwBRX6tlTqzlOkNXKFJqYGmLWvZ9WDysaNEfAhIcaMlMI/3ygGfLmajWqPhFF0s1q yT7MMOoKP/YEViRCuJ5mO2f4hMzUtha0fAnOq2umhbBZi0VcQ0vMSJrGAZoJytbmAFBTxB Jo4QqrkLTErYRR4AuF56fvGbFdAjnb6Gdd9bnE0wb1Il1fxN7ZzfA3Pcy7BI+FfXzq+yTq QSPBPJE2RvXKhiKEaXARp2eKHeRbb5B6myXbMlqM6stm/qlbobkrr8b1LuygZQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1723647974; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=kgBDpLd5CRpFg6iGANviJjQZYBMsab2XfI71ntFAp9M=; b=j6DzcVXm1ZA8IVRQAornEXvVYXU17kS2Dzdyv1mD/k0CSU+9aqtNO+Omhv5JKo36g68YUk Me2HS01vDRJm2JAA== To: Kevin Chen , robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, joel@jms.id.au, andrew@codeconstruct.com.au, kevin_chen@aspeedtech.com, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org Subject: Re: [PATCH v2 2/2] irqchip/aspeed-intc: Add support for AST27XX INTC In-Reply-To: <20240814114106.2809876-4-kevin_chen@aspeedtech.com> References: <20240814114106.2809876-1-kevin_chen@aspeedtech.com> <20240814114106.2809876-4-kevin_chen@aspeedtech.com> Date: Wed, 14 Aug 2024 17:06:14 +0200 Message-ID: <87plqbnnyx.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240814_080616_404506_813C994C X-CRM114-Status: GOOD ( 10.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Aug 14 2024 at 19:41, Kevin Chen wrote: > Support for the Aspeed Interrupt Controller found on Aspeed Silicon SoCs, > such as the AST2700, which is arm64 architecture. > > To support ASPEED interrupt controller(INTC) maps the internal interrupt > sources of the AST27XX device to an parent interrupt controller. This still lacks a Signed-off-by: tag and my comment about the error path in the init function is still valid. Do you think that addressing review feedback is optional? Feel free to ignore it, but don't be surprised if I ignore further patches from you. Take your time and go through stuff properly and do not rush out half baked patches in a frenzy. Thanks, tglx