From: Thomas Gleixner <tglx@linutronix.de>
To: "Marek Maślanka" <mmaslanka@google.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
"Rajneesh Bhardwaj" <irenic.rajneesh@gmail.com>,
"David E Box" <david.e.box@intel.com>,
"Hans de Goede" <hdegoede@redhat.com>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"John Stultz" <jstultz@google.com>,
"Stephen Boyd" <sboyd@kernel.org>,
platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH v3] platform/x86:intel/pmc: Enable the ACPI PM Timer to be turned off when suspended
Date: Wed, 31 Jul 2024 23:46:42 +0200 [thread overview]
Message-ID: <87plqt44l9.ffs@tglx> (raw)
In-Reply-To: <CAGcaFA2eXzzCVqG-DSWDb1gruV4FemRC3W+dgRub7GgcOyf7yQ@mail.gmail.com>
On Wed, Jul 31 2024 at 23:41, Marek Maślanka wrote:
> On Wed, Jul 31, 2024 at 6:33 PM Thomas Gleixner <tglx@linutronix.de> wrote:
>> On Wed, Jul 31 2024 at 16:44, Marek Maślanka wrote:
>> > Thanks. I'll try do this in that way. But I need to disable/enable
>> > ACPI PM timer only on suspend/resume, so I'll use suspend/resume
>> > callbacks.
>>
>> Why? What's the point of keeping it running when nothing uses it?
>>
> In case of Intel CPUs the watchdog (iTCO/wdat_wdt) is driven by ACPI PM
> Timer. But it may also be used by others that I don't know about, so I don't
> want to disable it.
Fair enough.
next prev parent reply other threads:[~2024-07-31 21:46 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-01 22:25 [PATCH] platform/x86:intel/pmc: Enable the ACPI PM Timer to be turned off when suspended Marek Maslanka
2024-07-02 8:02 ` Hans de Goede
2024-07-02 22:41 ` Marek Maślanka
2024-07-03 11:38 ` [PATCH v2] " Marek Maslanka
2024-07-03 16:30 ` Rajneesh Bhardwaj
2024-07-11 15:34 ` David E. Box
2024-07-15 12:39 ` Marek Maślanka
2024-07-30 12:05 ` [PATCH v3] " Marek Maslanka
2024-07-30 12:57 ` Ilpo Järvinen
2024-07-30 16:08 ` Thomas Gleixner
2024-07-31 14:44 ` Marek Maślanka
2024-07-31 16:33 ` Thomas Gleixner
2024-07-31 21:41 ` Marek Maślanka
2024-07-31 21:46 ` Thomas Gleixner [this message]
2024-08-06 7:24 ` Ilpo Järvinen
2024-08-09 13:13 ` [PATCH v4 1/2] clocksource: acpi_pm: Add external callback for suspend/resume Marek Maslanka
2024-08-09 13:13 ` [PATCH v4 2/2] platform/x86:intel/pmc: Enable the ACPI PM Timer to be turned off when suspended Marek Maslanka
2024-08-09 16:36 ` Thomas Gleixner
2024-08-12 4:40 ` [PATCH v5 " Marek Maslanka
2024-08-12 7:49 ` Ilpo Järvinen
2024-08-12 18:42 ` [PATCH v6 " Marek Maslanka
2024-08-19 11:31 ` Hans de Goede
2024-09-06 18:56 ` [tip: timers/core] " tip-bot2 for Marek Maslanka
2024-08-09 19:15 ` [PATCH v4 1/2] clocksource: acpi_pm: Add external callback for suspend/resume Thomas Gleixner
2024-08-12 4:37 ` [PATCH v5 " Marek Maslanka
2024-08-12 8:03 ` Hans de Goede
2024-08-12 18:41 ` [PATCH v6 " Marek Maslanka
2024-08-19 11:31 ` Hans de Goede
2024-08-19 11:35 ` Hans de Goede
2024-08-19 18:31 ` Daniel Lezcano
2024-09-06 18:56 ` [tip: timers/core] " tip-bot2 for Marek Maslanka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87plqt44l9.ffs@tglx \
--to=tglx@linutronix.de \
--cc=david.e.box@intel.com \
--cc=hdegoede@redhat.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=irenic.rajneesh@gmail.com \
--cc=jstultz@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mmaslanka@google.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.