From: Takashi Iwai <tiwai@suse.de>
To: soxiebing <soxiebing@163.com>
Cc: tiwai@suse.com, linux-sound@vger.kernel.org,
linux-kernel@vger.kernel.org,
songxiebing <songxiebing@kylinos.cn>,
bo liu <bo.liu@senarytech.com>
Subject: Re: [PATCH] ALSA: hda: conexant: Fix headset auto detect fail in the polling mode
Date: Thu, 25 Jul 2024 15:10:16 +0200 [thread overview]
Message-ID: <87plr1ipmv.wl-tiwai@suse.de> (raw)
In-Reply-To: <20240725082610.45504-1-soxiebing@163.com>
On Thu, 25 Jul 2024 10:26:10 +0200,
soxiebing wrote:
>
> From: songxiebing <songxiebing@kylinos.cn>
>
> 'Fixes: 7aeb25908648 ("Fix headset auto detect fail in cx8070 and SN6140")'
The Fixes tag should be put around Signed-off-by.
Also drop the quote ''.
> This patch only handles the unsol_event reporting during interrupts
> and does not include the polling mode used to set jackroll_ms, so
> it's changed to use snd_hda_jack_detect-enable_callback function.
If you mean about the commit above as "this patch", better to
rephrase to be clearer.
The code change itself looks good, through a quick glance.
Could you try to improve the patch description and resubmit?
thanks,
Takashi
next prev parent reply other threads:[~2024-07-25 13:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-25 8:26 [PATCH] ALSA: hda: conexant: Fix headset auto detect fail in the polling mode soxiebing
2024-07-25 13:10 ` Takashi Iwai [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-07-26 1:23 soxiebing
2024-07-26 7:08 ` Takashi Iwai
2024-07-26 9:41 ` soxiebing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87plr1ipmv.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=bo.liu@senarytech.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=songxiebing@kylinos.cn \
--cc=soxiebing@163.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.