All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@kernel.org>
To: Aaradhana Sahu <quic_aarasahu@quicinc.com>
Cc: <ath12k@lists.infradead.org>,  <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH v5 3/4] wifi: ath12k: add factory test mode support
Date: Tue, 02 Jul 2024 13:18:42 +0300	[thread overview]
Message-ID: <87plrwf665.fsf@kernel.org> (raw)
In-Reply-To: <20240624095305.37189-4-quic_aarasahu@quicinc.com> (Aaradhana Sahu's message of "Mon, 24 Jun 2024 15:23:04 +0530")

Aaradhana Sahu <quic_aarasahu@quicinc.com> writes:

> Add support to process factory test mode commands(FTM) for calibration.
> By default firmware start with MISSION mode and to process the FTM commands
> firmware needs to be restarted in FTM mode using module parameter ftm_mode.
> The pre-request is all the radios should be down before starting the test.
>
> All ath12k test mode interface related commands specified in enum
> ath_tm_cmd.
>
> When start command ATH_TM_CMD_TESTMODE_START is received, ar state
> is set to test Mode and FTM daemon sends test mode command to wifi
> driver via cfg80211. Wifi driver sends these command to firmware as
> wmi events. If it is segmented commands it will be broken down into
> multiple segments and encoded with TLV header else it is sent to
> firmware as it is.
>
> Firmware response via UTF events, wifi driver creates skb and send
> to cfg80211, cfg80211 sends firmware response to FTM daemon via
> netlink message.
>
> Command to boot in ftm mode
> insmod ath12k ftm_mode=1
>
> Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.1.1-00210-QCAHKSWPL_SILICONZ-1
>
> Signed-off-by: Aaradhana Sahu <quic_aarasahu@quicinc.com>

[...]

> --- a/drivers/net/wireless/ath/ath12k/core.c
> +++ b/drivers/net/wireless/ath/ath12k/core.c
> @@ -42,6 +42,10 @@ static int ath12k_core_rfkill_config(struct ath12k_base *ab)
>  	return ret;
>  }
>  
> +bool ath12k_ftm_mode;
> +module_param_named(ftm_mode, ath12k_ftm_mode, bool, 0444);
> +MODULE_PARM_DESC(ftm_mode, "Boots up in factory test mode");

In the pending branch I moved these to the beginning of the file,
otherwise they are quite hidden:

https://git.kernel.org/pub/scm/linux/kernel/git/ath/ath.git/commit/?h=pending&id=0006b23098b2cb0dded6c650ef9b5a590bfb5a3c

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches


  parent reply	other threads:[~2024-07-02 10:18 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-24  9:53 [PATCH v5 0/4] wifi: ath12k: Factory test mode support Aaradhana Sahu
2024-06-24  9:53 ` [PATCH v5 1/4] wifi: ath: create common testmode_i.h file for ath drivers Aaradhana Sahu
2024-06-25 18:43   ` Jeff Johnson
2024-06-24  9:53 ` [PATCH v5 2/4] wifi: ath12k: export ath12k_wmi_tlv_hdr for testmode Aaradhana Sahu
2024-06-25 18:43   ` Jeff Johnson
2024-06-24  9:53 ` [PATCH v5 3/4] wifi: ath12k: add factory test mode support Aaradhana Sahu
2024-06-25 18:44   ` Jeff Johnson
2024-06-27 17:43   ` Kalle Valo
2024-06-27 18:29     ` Jeff Johnson
2024-06-28  3:19     ` Aaradhana Sahu
2024-07-02 10:18   ` Kalle Valo [this message]
2024-07-02 13:49   ` Kalle Valo
2024-06-24  9:53 ` [PATCH v5 4/4] wifi: ath12k: Fill pdev id for fw test cmd Aaradhana Sahu
2024-06-25 18:44   ` Jeff Johnson
2025-01-09  4:43 ` [PATCH v5 0/4] wifi: ath12k: Factory test mode support Aaradhana Sahu
2025-01-09  4:55   ` Aditya Kumar Singh
2025-01-09  5:29     ` Jeff Johnson
2025-01-09 12:54       ` Kalle Valo
2025-01-09 13:15         ` Aaradhana Sahu
2025-01-09 20:53           ` Jeff Johnson
2025-01-09 13:14       ` Aaradhana Sahu
2025-01-09 13:13     ` Aaradhana Sahu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87plrwf665.fsf@kernel.org \
    --to=kvalo@kernel.org \
    --cc=ath12k@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=quic_aarasahu@quicinc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.